Re: [PATCH v7 16/21] target/loongarch: Add disassembler

2021-10-20 Thread Song Gao
Hi, all. On 10/19/2021 02:57 AM, Philippe Mathieu-Daudé wrote: > On 10/18/21 20:33, Richard Henderson wrote: >> On 10/18/21 11:18 AM, WANG Xuerui wrote: >>> On 10/19/21 01:29, Richard Henderson wrote: On 10/18/21 8:38 AM, WANG Xuerui wrote: > > For now any implementation would suffice

Re: [PATCH v7 16/21] target/loongarch: Add disassembler

2021-10-18 Thread Philippe Mathieu-Daudé
On 10/18/21 20:33, Richard Henderson wrote: > On 10/18/21 11:18 AM, WANG Xuerui wrote: >> On 10/19/21 01:29, Richard Henderson wrote: >>> On 10/18/21 8:38 AM, WANG Xuerui wrote: For now any implementation would suffice, and I already saw one or two bugs in the output during my TCG ho

Re: [PATCH v7 16/21] target/loongarch: Add disassembler

2021-10-18 Thread Richard Henderson
On 10/18/21 11:18 AM, WANG Xuerui wrote: On 10/19/21 01:29, Richard Henderson wrote: On 10/18/21 8:38 AM, WANG Xuerui wrote: For now any implementation would suffice, and I already saw one or two bugs in the output during my TCG host work, but it surely would be nice to switch to generated

Re: [PATCH v7 16/21] target/loongarch: Add disassembler

2021-10-18 Thread WANG Xuerui
On 10/19/21 01:29, Richard Henderson wrote: On 10/18/21 8:38 AM, WANG Xuerui wrote: For now any implementation would suffice, and I already saw one or two bugs in the output during my TCG host work, but it surely would be nice to switch to generated decoder in the future. The loongarch-opc

Re: [PATCH v7 16/21] target/loongarch: Add disassembler

2021-10-18 Thread Richard Henderson
On 10/18/21 8:38 AM, WANG Xuerui wrote: For now any implementation would suffice, and I already saw one or two bugs in the output during my TCG host work, but it surely would be nice to switch to generated decoder in the future. The loongarch-opcodes tables could be extended to support peculia

Re: [PATCH v7 16/21] target/loongarch: Add disassembler

2021-10-18 Thread WANG Xuerui
Hi Song, On 10/18/21 20:47, Song Gao wrote: This patch add support for disassembling via option '-d in_asm'. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Acked-by: Richard Henderson --- MAINTAINERS |1 + disas/loongarch.c | 2511 ++

[PATCH v7 16/21] target/loongarch: Add disassembler

2021-10-18 Thread Song Gao
This patch add support for disassembling via option '-d in_asm'. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Acked-by: Richard Henderson --- MAINTAINERS |1 + disas/loongarch.c | 2511 +++ disas/meson.build |1