Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-04-19 Thread Igor Mammedov
On Wed, 13 Apr 2022 15:08:33 -0400 Peter Xu wrote: > On Wed, Apr 13, 2022 at 04:37:35PM +0200, Igor Mammedov wrote: > > On Thu, 31 Mar 2022 08:41:01 -0400 > > Peter Xu wrote: > > > > > On Thu, Mar 31, 2022 at 10:47:33AM +0100, Stefan Hajnoczi wrote: > > > > On Wed, Mar 30, 2022 at 01:13:03P

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-04-13 Thread Jag Raman
> On Apr 13, 2022, at 2:24 PM, Jag Raman wrote: > > > >> On Apr 13, 2022, at 10:25 AM, Igor Mammedov wrote: >> >> On Fri, 25 Mar 2022 15:19:41 -0400 >> Jagannathan Raman wrote: >> >>> Assign separate address space for each device in the remote processes. >>> >>> Signed-off-by: Elena Ufim

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-04-13 Thread Peter Xu
On Wed, Apr 13, 2022 at 04:37:35PM +0200, Igor Mammedov wrote: > On Thu, 31 Mar 2022 08:41:01 -0400 > Peter Xu wrote: > > > On Thu, Mar 31, 2022 at 10:47:33AM +0100, Stefan Hajnoczi wrote: > > > On Wed, Mar 30, 2022 at 01:13:03PM -0400, Peter Xu wrote: > > > > On Wed, Mar 30, 2022 at 05:08:24PM

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-04-13 Thread Jag Raman
> On Apr 13, 2022, at 10:25 AM, Igor Mammedov wrote: > > On Fri, 25 Mar 2022 15:19:41 -0400 > Jagannathan Raman wrote: > >> Assign separate address space for each device in the remote processes. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jaganna

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-04-13 Thread Igor Mammedov
On Thu, 31 Mar 2022 08:41:01 -0400 Peter Xu wrote: > On Thu, Mar 31, 2022 at 10:47:33AM +0100, Stefan Hajnoczi wrote: > > On Wed, Mar 30, 2022 at 01:13:03PM -0400, Peter Xu wrote: > > > On Wed, Mar 30, 2022 at 05:08:24PM +0100, Stefan Hajnoczi wrote: > > > > On Wed, Mar 30, 2022 at 08:53:16AM

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-04-13 Thread Igor Mammedov
On Fri, 25 Mar 2022 15:19:41 -0400 Jagannathan Raman wrote: > Assign separate address space for each device in the remote processes. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > include/hw/remote/iommu.h | 18 > hw/rem

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-31 Thread Peter Xu
On Thu, Mar 31, 2022 at 10:47:33AM +0100, Stefan Hajnoczi wrote: > On Wed, Mar 30, 2022 at 01:13:03PM -0400, Peter Xu wrote: > > On Wed, Mar 30, 2022 at 05:08:24PM +0100, Stefan Hajnoczi wrote: > > > On Wed, Mar 30, 2022 at 08:53:16AM -0400, Peter Xu wrote: > > > > On Wed, Mar 30, 2022 at 11:04:24A

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-31 Thread Stefan Hajnoczi
On Wed, Mar 30, 2022 at 01:13:03PM -0400, Peter Xu wrote: > On Wed, Mar 30, 2022 at 05:08:24PM +0100, Stefan Hajnoczi wrote: > > On Wed, Mar 30, 2022 at 08:53:16AM -0400, Peter Xu wrote: > > > On Wed, Mar 30, 2022 at 11:04:24AM +0100, Stefan Hajnoczi wrote: > > > > This makes me wonder whether ther

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-30 Thread Peter Xu
On Wed, Mar 30, 2022 at 05:08:24PM +0100, Stefan Hajnoczi wrote: > On Wed, Mar 30, 2022 at 08:53:16AM -0400, Peter Xu wrote: > > On Wed, Mar 30, 2022 at 11:04:24AM +0100, Stefan Hajnoczi wrote: > > > This makes me wonder whether there is a deeper issue with the > > > pci_setup_iommu() API: the lack

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-30 Thread Stefan Hajnoczi
On Wed, Mar 30, 2022 at 08:53:16AM -0400, Peter Xu wrote: > On Wed, Mar 30, 2022 at 11:04:24AM +0100, Stefan Hajnoczi wrote: > > This makes me wonder whether there is a deeper issue with the > > pci_setup_iommu() API: the lack of per-device cleanup callbacks. > > Per-device IOMMU resources should b

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-30 Thread Peter Xu
On Wed, Mar 30, 2022 at 11:04:24AM +0100, Stefan Hajnoczi wrote: > This makes me wonder whether there is a deeper issue with the > pci_setup_iommu() API: the lack of per-device cleanup callbacks. > Per-device IOMMU resources should be freed when a device is hot > unplugged. > > From what I can tel

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-30 Thread Stefan Hajnoczi
On Tue, Mar 29, 2022 at 07:58:51PM +, Jag Raman wrote: > > > > On Mar 29, 2022, at 10:48 AM, Stefan Hajnoczi wrote: > > > > On Tue, Mar 29, 2022 at 02:12:40PM +, Jag Raman wrote: > >>> On Mar 29, 2022, at 8:35 AM, Stefan Hajnoczi wrote: > >>> On Fri, Mar 25, 2022 at 03:19:41PM -0400, J

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 10:48 AM, Stefan Hajnoczi wrote: > > On Tue, Mar 29, 2022 at 02:12:40PM +, Jag Raman wrote: >>> On Mar 29, 2022, at 8:35 AM, Stefan Hajnoczi wrote: >>> On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: +void remote_iommu_del_device(PCIDevice *pci

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Stefan Hajnoczi
On Tue, Mar 29, 2022 at 02:12:40PM +, Jag Raman wrote: > > On Mar 29, 2022, at 8:35 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: > >> +void remote_iommu_del_device(PCIDevice *pci_dev) > >> +{ > >> +int pci_bdf; > >> + > >> +if (!remo

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 8:35 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: >> Assign separate address space for each device in the remote processes. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagan

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Stefan Hajnoczi
On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: > Assign separate address space for each device in the remote processes. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > include/hw/remote/iommu.h | 18 > h

[PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-25 Thread Jagannathan Raman
Assign separate address space for each device in the remote processes. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/hw/remote/iommu.h | 18 hw/remote/iommu.c | 95 +++ MAINTAINERS