Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-03-01 Thread Alex Williamson
On Fri, 1 Mar 2024 08:33:42 + Ankit Agrawal wrote: > >> As for your suggestion of using acpi-dev as the arg to take both > >> pci-dev and acpi-dev.. Would that mean sending a pure pci device > >> (not the corner case you mentioned) through the acpi-dev argument > >> as well? Not sure if that

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-03-01 Thread Ankit Agrawal
>> As for your suggestion of using acpi-dev as the arg to take both >> pci-dev and acpi-dev.. Would that mean sending a pure pci device >> (not the corner case you mentioned) through the acpi-dev argument >> as well? Not sure if that would appropriate. > > Ah, looking up my description is unclear.

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-29 Thread Jonathan Cameron via
On Thu, 29 Feb 2024 13:00:27 + Ankit Agrawal wrote: > >> >>> Jonathan, you pointed out interface design issues in your review of > >> >>> v2.> > >> >> Are you fully satisfied with the interface in v3? > >> >> > >> >> Yes. I'm fine with the interface in this version (though it's v7, so > >

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-29 Thread Ankit Agrawal
>> >>> Jonathan, you pointed out interface design issues in your review of v2.> >> >> Are you fully satisfied with the interface in v3? >> >> >> >> Yes. I'm fine with the interface in this version (though it's v7, so I'm >> >> lost >> >> on v2 vs v3!) >> > >> > Looks like I can't count to 7! >> >

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-29 Thread Jonathan Cameron via
On Wed, 28 Feb 2024 16:50:30 + Ankit Agrawal wrote: > >>> Jonathan, you pointed out interface design issues in your review of v2.> > >> Are you fully satisfied with the interface in v3? > >> > >> Yes. I'm fine with the interface in this version (though it's v7, so I'm > >> lost > >> on v2

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-28 Thread Ankit Agrawal
>>> Jonathan, you pointed out interface design issues in your review of v2.> >> Are you fully satisfied with the interface in v3? >> >> Yes. I'm fine with the interface in this version (though it's v7, so I'm lost >> on v2 vs v3!) > > Looks like I can't count to 7! > > With NUMA capitalized in the

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-28 Thread Markus Armbruster
Jonathan Cameron writes: >> > ## >> > # @RngProperties: >> > # >> > @@ -911,6 +926,7 @@ >> > ## >> > { 'enum': 'ObjectType', >> >'data': [ >> > +'acpi-generic-initiator', >> > 'authz-list', >> > 'authz-listfile', >> > 'authz-pam', >> > @@ -981,6 +997,7 @@ >> >

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-28 Thread Jonathan Cameron via
> > ## > > # @RngProperties: > > # > > @@ -911,6 +926,7 @@ > > ## > > { 'enum': 'ObjectType', > >'data': [ > > +'acpi-generic-initiator', > > 'authz-list', > > 'authz-listfile', > > 'authz-pam', > > @@ -981,6 +997,7 @@ > > 'id': 'str' }, > >'discrimina

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-27 Thread Markus Armbruster
writes: > From: Ankit Agrawal > > NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows > partitioning of the GPU device resources (including device memory) into > several (upto 8) isolated instances. Each of the partitioned memory needs > a dedicated NUMA node to operate. The

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-27 Thread Ankit Agrawal
>> diff --git a/include/hw/acpi/acpi-generic-initiator.h >> b/include/hw/acpi/acpi-generic-initiator.h >> new file mode 100644 >> index 00..2f183b029a >> --- /dev/null >> +++ b/include/hw/acpi/acpi-generic-initiator.h > >> +typedef struct AcpiGenericInitiatorClass { >> +    ObjectClass

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-27 Thread Jonathan Cameron via
> diff --git a/include/hw/acpi/acpi-generic-initiator.h > b/include/hw/acpi/acpi-generic-initiator.h > new file mode 100644 > index 00..2f183b029a > --- /dev/null > +++ b/include/hw/acpi/acpi-generic-initiator.h > +typedef struct AcpiGenericInitiatorClass { > +ObjectClass parent

[PATCH v7 1/2] qom: new object to associate device to numa node

2024-02-23 Thread ankita
From: Ankit Agrawal NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows partitioning of the GPU device resources (including device memory) into several (upto 8) isolated instances. Each of the partitioned memory needs a dedicated NUMA node to operate. The partitions are not fi