Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-06 Thread Peter Maydell
On Mon, 6 Jul 2020 at 06:52, Markus Armbruster wrote: > This is TYPE_SD_CARD's ("sd-card"). What exactly does that device > model? It is I think supposed to be an SD card. The modelling may well be odd -- it's a qomification of a pre-existing abstraction layer that predates QOM and qbus. > If i

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-05 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: >> >> As we have no interest in the underlying block geometry, >> directly call blk_getlength(). We have to care about machines >> creating SD card with not drive attached (probably incorrect >> API use). Simply

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-05 Thread Philippe Mathieu-Daudé
On 7/5/20 12:26 AM, Philippe Mathieu-Daudé wrote: > On 7/5/20 12:18 AM, Philippe Mathieu-Daudé wrote: >> On 7/5/20 12:10 AM, Philippe Mathieu-Daudé wrote: >>> On 7/4/20 1:42 AM, Philippe Mathieu-Daudé wrote: On 7/3/20 5:16 PM, Philippe Mathieu-Daudé wrote: > On 7/3/20 3:23 PM, Peter Maydel

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-04 Thread Philippe Mathieu-Daudé
On 7/5/20 12:18 AM, Philippe Mathieu-Daudé wrote: > On 7/5/20 12:10 AM, Philippe Mathieu-Daudé wrote: >> On 7/4/20 1:42 AM, Philippe Mathieu-Daudé wrote: >>> On 7/3/20 5:16 PM, Philippe Mathieu-Daudé wrote: On 7/3/20 3:23 PM, Peter Maydell wrote: > On Tue, 30 Jun 2020 at 14:39, Philippe Ma

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-04 Thread Philippe Mathieu-Daudé
On 7/5/20 12:10 AM, Philippe Mathieu-Daudé wrote: > On 7/4/20 1:42 AM, Philippe Mathieu-Daudé wrote: >> On 7/3/20 5:16 PM, Philippe Mathieu-Daudé wrote: >>> On 7/3/20 3:23 PM, Peter Maydell wrote: On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > As we have no inte

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-04 Thread Philippe Mathieu-Daudé
On 7/4/20 1:42 AM, Philippe Mathieu-Daudé wrote: > On 7/3/20 5:16 PM, Philippe Mathieu-Daudé wrote: >> On 7/3/20 3:23 PM, Peter Maydell wrote: >>> On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé >>> wrote: As we have no interest in the underlying block geometry, directly call

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-03 Thread Philippe Mathieu-Daudé
On 7/3/20 5:16 PM, Philippe Mathieu-Daudé wrote: > On 7/3/20 3:23 PM, Peter Maydell wrote: >> On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: >>> >>> As we have no interest in the underlying block geometry, >>> directly call blk_getlength(). We have to care about machines >>> creating

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-03 Thread Philippe Mathieu-Daudé
On 7/3/20 3:23 PM, Peter Maydell wrote: > On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: >> >> As we have no interest in the underlying block geometry, >> directly call blk_getlength(). We have to care about machines >> creating SD card with not drive attached (probably incorrect >> A

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > As we have no interest in the underlying block geometry, > directly call blk_getlength(). We have to care about machines > creating SD card with not drive attached (probably incorrect > API use). Simply emit a warning when such Franke

[PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

2020-06-30 Thread Philippe Mathieu-Daudé
As we have no interest in the underlying block geometry, directly call blk_getlength(). We have to care about machines creating SD card with not drive attached (probably incorrect API use). Simply emit a warning when such Frankenstein cards of zero size are reset. Signed-off-by: Philippe Mathieu-D