Re: [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-07 Thread Philippe Mathieu-Daudé
On 7/7/20 12:24 PM, Philippe Mathieu-Daudé wrote: > On 7/7/20 10:30 AM, Philippe Mathieu-Daudé wrote: >> On Tue, Jun 30, 2020 at 3:39 PM Philippe Mathieu-Daudé >> wrote: >>> >>> Only move the state machine to ReceivingData if there is no >>> pending error. This avoids later OOB access while proce

Re: [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-07 Thread Philippe Mathieu-Daudé
On 7/7/20 10:30 AM, Philippe Mathieu-Daudé wrote: > On Tue, Jun 30, 2020 at 3:39 PM Philippe Mathieu-Daudé > wrote: >> >> Only move the state machine to ReceivingData if there is no >> pending error. This avoids later OOB access while processing >> commands queued. >> >> "SD Specifications Part

Re: [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-07 Thread Philippe Mathieu-Daudé
On Tue, Jun 30, 2020 at 3:39 PM Philippe Mathieu-Daudé wrote: > > Only move the state machine to ReceivingData if there is no > pending error. This avoids later OOB access while processing > commands queued. > > "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" > > 4.3.3 Data Re

Re: [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-06 Thread Alistair Francis
On Tue, Jun 30, 2020 at 6:42 AM Philippe Mathieu-Daudé wrote: > > Only move the state machine to ReceivingData if there is no > pending error. This avoids later OOB access while processing > commands queued. > > "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" > > 4.3.3 Data Re

Re: [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-03 Thread Peter Maydell
On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote: > > Only move the state machine to ReceivingData if there is no > pending error. This avoids later OOB access while processing > commands queued. > > "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" > > 4.3.3 Data Read

[PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-06-30 Thread Philippe Mathieu-Daudé
Only move the state machine to ReceivingData if there is no pending error. This avoids later OOB access while processing commands queued. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.3 Data Read Read command is rejected if BLOCK_LEN_ERROR or ADDRESS_ERROR occurred