Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-03-04 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 23.02.2020 11:55, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and >>> does corresponding changes in code (look for details in >>> include/qapi/error.h) >>> >>> Us

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-03-04 Thread Vladimir Sementsov-Ogievskiy
23.02.2020 11:55, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file scripts/coccinelle/auto-propagat

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-02-25 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 25.02.2020 15:52, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 23.02.2020 11:55, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-02-25 Thread Vladimir Sementsov-Ogievskiy
25.02.2020 15:52, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 23.02.2020 11:55, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in inc

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-02-25 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 23.02.2020 11:55, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and >>> does corresponding changes in code (look for details in >>> include/qapi/error.h) >>> >>> Us

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2020 11:55, Markus Armbruster wrote: +| +-warn_report_err(local_err); ++warn_report_errp(errp); Likewise. What about error_reportf_err(), warn_reportf_err()? Hmm I'm afraid, we don't have corresponding cases to update.. We can still handle them here, but, then, should we use no

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2020 11:55, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file scripts/coccinelle/auto-propagat

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-02-23 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and > does corresponding changes in code (look for details in > include/qapi/error.h) > > Usage example: > spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ > --macro-file scr

[PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \