Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-21 Thread Markus Armbruster
Markus Armbruster writes: > The appended incremental patch conditionalizes the enum. It applies on > top of the series, and passes "make check" for me. Seems to contradict > "we can't make the enum values conditional". Neglected to mention that query-accel becomes almost useless in this versio

Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-21 Thread Markus Armbruster
Markus Armbruster writes: > Philippe Mathieu-Daudé writes: > >> Introduce the 'query-accels' QMP command which returns a list >> of built-in accelerator names. >> >> - Accelerator is a QAPI enum of all existing accelerators, >> >> - AcceleratorInfo is a QAPI structure providing accelerator >>

Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-21 Thread Philippe Mathieu-Daudé
On 5/5/21 9:41 PM, Eduardo Habkost wrote: > On Wed, May 05, 2021 at 02:57:56PM +0200, Philippe Mathieu-Daudé wrote: >> Introduce the 'query-accels' QMP command which returns a list >> of built-in accelerator names. >> >> - Accelerator is a QAPI enum of all existing accelerators, >> >> - Accelerator

Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Introduce the 'query-accels' QMP command which returns a list > of built-in accelerator names. > > - Accelerator is a QAPI enum of all existing accelerators, > > - AcceleratorInfo is a QAPI structure providing accelerator > specific information. Currently the co

Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-05 Thread Eduardo Habkost
On Wed, May 05, 2021 at 02:57:56PM +0200, Philippe Mathieu-Daudé wrote: > Introduce the 'query-accels' QMP command which returns a list > of built-in accelerator names. > > - Accelerator is a QAPI enum of all existing accelerators, > > - AcceleratorInfo is a QAPI structure providing accelerator >

[PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-05 Thread Philippe Mathieu-Daudé
Introduce the 'query-accels' QMP command which returns a list of built-in accelerator names. - Accelerator is a QAPI enum of all existing accelerators, - AcceleratorInfo is a QAPI structure providing accelerator specific information. Currently the common structure base provides the name of th