Re: [PATCH v7 00/11] Implementation of NPI Mailbox and GMAC Networking Module

2023-12-14 Thread Peter Maydell
On Thu, 14 Dec 2023 at 11:43, Peter Maydell wrote: > > On Mon, 11 Dec 2023 at 17:52, Nabih Estefan wrote: > > > > From: Nabih Estefan Diaz > > > > [Changes since v6] > > Remove the Change-Ids from the commit messages. > > > > This doesn't compile: > > ../../hw/net/npcm_gmac.c:889:43: error: too

Re: [PATCH v7 00/11] Implementation of NPI Mailbox and GMAC Networking Module

2023-12-14 Thread Peter Maydell
On Mon, 11 Dec 2023 at 17:52, Nabih Estefan wrote: > > From: Nabih Estefan Diaz > > [Changes since v6] > Remove the Change-Ids from the commit messages. > This doesn't compile: ../../hw/net/npcm_gmac.c:889:43: error: too few arguments to function call, expected 6, have 5

[PATCH v7 00/11] Implementation of NPI Mailbox and GMAC Networking Module

2023-12-11 Thread Nabih Estefan
From: Nabih Estefan Diaz [Changes since v6] Remove the Change-Ids from the commit messages. [Changes since v5] Undid remove of some qtests that seem to have been caused by a merge conflict. [Changes since v4] Added Signed-off-by tag and fixed patch 4 commit message as suggested by Peter Maydell