Re: [PATCH v6 34/60] i386/tdx: implement tdx_cpu_realizefn()

2025-01-14 Thread Daniel P . Berrangé
On Tue, Jan 14, 2025 at 04:52:07PM +0800, Xiaoyao Li wrote: > On 12/13/2024 6:04 AM, Ira Weiny wrote: > > On Tue, Nov 05, 2024 at 12:53:25PM +0100, Paolo Bonzini wrote: > > > On 11/5/24 12:38, Xiaoyao Li wrote: > > > > On 11/5/2024 6:06 PM, Paolo Bonzini wrote: > > > > > On 11/5/24 07:23, Xiaoyao L

Re: [PATCH v6 34/60] i386/tdx: implement tdx_cpu_realizefn()

2025-01-14 Thread Xiaoyao Li
On 12/13/2024 6:04 AM, Ira Weiny wrote: On Tue, Nov 05, 2024 at 12:53:25PM +0100, Paolo Bonzini wrote: On 11/5/24 12:38, Xiaoyao Li wrote: On 11/5/2024 6:06 PM, Paolo Bonzini wrote: On 11/5/24 07:23, Xiaoyao Li wrote: +static void tdx_cpu_realizefn(X86ConfidentialGuest *cg, CPUState *cs, +   

Re: [PATCH v6 34/60] i386/tdx: implement tdx_cpu_realizefn()

2024-12-12 Thread Ira Weiny
On Tue, Nov 05, 2024 at 12:53:25PM +0100, Paolo Bonzini wrote: > On 11/5/24 12:38, Xiaoyao Li wrote: > > On 11/5/2024 6:06 PM, Paolo Bonzini wrote: > > > On 11/5/24 07:23, Xiaoyao Li wrote: > > > > +static void tdx_cpu_realizefn(X86ConfidentialGuest *cg, CPUState *cs, > > > > + 

Re: [PATCH v6 34/60] i386/tdx: implement tdx_cpu_realizefn()

2024-11-05 Thread Paolo Bonzini
On 11/5/24 12:38, Xiaoyao Li wrote: On 11/5/2024 6:06 PM, Paolo Bonzini wrote: On 11/5/24 07:23, Xiaoyao Li wrote: +static void tdx_cpu_realizefn(X86ConfidentialGuest *cg, CPUState *cs, +  Error **errp) +{ +    X86CPU *cpu = X86_CPU(cs); +    uint32_t host_phys_bits

Re: [PATCH v6 34/60] i386/tdx: implement tdx_cpu_realizefn()

2024-11-05 Thread Xiaoyao Li
On 11/5/2024 6:06 PM, Paolo Bonzini wrote: On 11/5/24 07:23, Xiaoyao Li wrote: +static void tdx_cpu_realizefn(X86ConfidentialGuest *cg, CPUState *cs, +  Error **errp) +{ +    X86CPU *cpu = X86_CPU(cs); +    uint32_t host_phys_bits = host_cpu_phys_bits(); + +    if (!c

Re: [PATCH v6 34/60] i386/tdx: implement tdx_cpu_realizefn()

2024-11-05 Thread Paolo Bonzini
On 11/5/24 07:23, Xiaoyao Li wrote: +static void tdx_cpu_realizefn(X86ConfidentialGuest *cg, CPUState *cs, + Error **errp) +{ +X86CPU *cpu = X86_CPU(cs); +uint32_t host_phys_bits = host_cpu_phys_bits(); + +if (!cpu->phys_bits) { +cpu->phys_bits = h

[PATCH v6 34/60] i386/tdx: implement tdx_cpu_realizefn()

2024-11-04 Thread Xiaoyao Li
For TDX guest, KVM doesn't allow phys_bits configuration and the phys_bits can only be native/host value. Add the logic to set cpu->phys_bits to host value when user doesn't give a explicit one and error out when user desires a different one than host value. Signed-off-by: Xiaoyao Li --- Changes