Re: [PATCH v6 3/4] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-09-11 Thread Stefan Hajnoczi
On Thu, Sep 10, 2020 at 05:29:25PM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefan, Alex. > > On 9/10/20 12:44 PM, Stefan Hajnoczi wrote: > > On Wed, Sep 09, 2020 at 04:23:53PM +0200, Philippe Mathieu-Daudé wrote: > >> +/** > >> + * Initialize device MSIX IRQs and register event notifiers. > >>

Re: [PATCH v6 3/4] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-09-10 Thread Philippe Mathieu-Daudé
On 9/10/20 6:29 PM, Alex Williamson wrote: > On Thu, 10 Sep 2020 17:29:25 +0200 > Philippe Mathieu-Daudé wrote: > >> Hi Stefan, Alex. >> >> On 9/10/20 12:44 PM, Stefan Hajnoczi wrote: >>> On Wed, Sep 09, 2020 at 04:23:53PM +0200, Philippe Mathieu-Daudé wrote: +/** + * Initialize devi

Re: [PATCH v6 3/4] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-09-10 Thread Alex Williamson
On Thu, 10 Sep 2020 17:29:25 +0200 Philippe Mathieu-Daudé wrote: > Hi Stefan, Alex. > > On 9/10/20 12:44 PM, Stefan Hajnoczi wrote: > > On Wed, Sep 09, 2020 at 04:23:53PM +0200, Philippe Mathieu-Daudé wrote: > >> +/** > >> + * Initialize device MSIX IRQs and register event notifiers. > >> + *

Re: [PATCH v6 3/4] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-09-10 Thread Philippe Mathieu-Daudé
Hi Stefan, Alex. On 9/10/20 12:44 PM, Stefan Hajnoczi wrote: > On Wed, Sep 09, 2020 at 04:23:53PM +0200, Philippe Mathieu-Daudé wrote: >> +/** >> + * Initialize device MSIX IRQs and register event notifiers. >> + * @irq_count: pointer to number of MSIX IRQs to initialize >> + * @notifier: Array o

Re: [PATCH v6 3/4] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-09-10 Thread Stefan Hajnoczi
On Wed, Sep 09, 2020 at 04:23:53PM +0200, Philippe Mathieu-Daudé wrote: > +/** > + * Initialize device MSIX IRQs and register event notifiers. > + * @irq_count: pointer to number of MSIX IRQs to initialize > + * @notifier: Array of @irq_count notifiers (each corresponding to a MSIX > IRQ) > + > +

[PATCH v6 3/4] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-09-09 Thread Philippe Mathieu-Daudé
qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ, but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is specific to MSIX IRQ type, and allow us to use multiple IRQs (thus passing multiple eventfd notifiers). Reviewed-by: Fam Zheng Signed-off-by: Philippe Mathieu-Daudé -