Re: [PATCH v6 2/4] Add NVMM accelerator: x86 CPU support

2021-04-01 Thread Paolo Bonzini
On 01/04/21 14:32, Reinoud Zandijk wrote: On Thu, Apr 01, 2021 at 10:35:40AM +0200, Paolo Bonzini wrote: On 31/03/21 22:07, Reinoud Zandijk wrote: +void nvmm_vcpu_kick(CPUState *cpu); Not defined anywhere. Hmmm, indeed. I think its a leftover of the former patch. Good catch. +{ +#if NVMM_

Re: [PATCH v6 2/4] Add NVMM accelerator: x86 CPU support

2021-04-01 Thread Reinoud Zandijk
On Thu, Apr 01, 2021 at 10:35:40AM +0200, Paolo Bonzini wrote: > On 31/03/21 22:07, Reinoud Zandijk wrote: > > +void nvmm_vcpu_kick(CPUState *cpu); > > Not defined anywhere. Hmmm, indeed. I think its a leftover of the former patch. Good catch. > > +{ > > +#if NVMM_USER_VERSION == 1 > > +stru

Re: [PATCH v6 2/4] Add NVMM accelerator: x86 CPU support

2021-04-01 Thread Paolo Bonzini
On 31/03/21 22:07, Reinoud Zandijk wrote: +void nvmm_vcpu_kick(CPUState *cpu); Not defined anywhere. +{ +#if NVMM_USER_VERSION == 1 +struct sigaction sigact; +sigset_t set; + +/* Install the IPI handler. */ +memset(&sigact, 0, sizeof(sigact)); +sigact.sa_handler = nvmm_ipi

[PATCH v6 2/4] Add NVMM accelerator: x86 CPU support

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- target/i386/meson.build |1 + target/i386/nvmm/meson.build |4 + target/i386/nvmm/nvmm-accel-ops.c | 111 +++ target/i386/nvmm/nvmm-accel-ops.h | 25 + target/i386/nvmm/nvmm-all.c | 1231 +