Re: [PATCH v6 06/18] hw/arm/allwinner: add CPU Configuration module

2020-03-10 Thread Niek Linnenbank
On Mon, Mar 9, 2020 at 12:18 PM Peter Maydell wrote: > On Tue, 3 Mar 2020 at 20:15, Niek Linnenbank > wrote: > > On Tue, Mar 3, 2020 at 1:09 PM Alex Bennée > wrote: > >> Niek Linnenbank writes: > >> > +static void allwinner_cpucfg_cpu_reset(AwCpuCfgState *s, uint8_t > cpu_id) > >> > +{ > >> >

Re: [PATCH v6 06/18] hw/arm/allwinner: add CPU Configuration module

2020-03-09 Thread Peter Maydell
On Tue, 3 Mar 2020 at 20:15, Niek Linnenbank wrote: > On Tue, Mar 3, 2020 at 1:09 PM Alex Bennée wrote: >> Niek Linnenbank writes: >> > +static void allwinner_cpucfg_cpu_reset(AwCpuCfgState *s, uint8_t cpu_id) >> > +{ >> > +int ret; >> > + >> > +trace_allwinner_cpucfg_cpu_reset(cpu_id, s

Re: [PATCH v6 06/18] hw/arm/allwinner: add CPU Configuration module

2020-03-03 Thread Niek Linnenbank
Hi Alex, First thanks for all your reviews, I'll add the tags in the next version of this series. On Tue, Mar 3, 2020 at 1:09 PM Alex Bennée wrote: > > Niek Linnenbank writes: > > > Various Allwinner System on Chip designs contain multiple processors > > that can be configured and reset using

Re: [PATCH v6 06/18] hw/arm/allwinner: add CPU Configuration module

2020-03-03 Thread Alex Bennée
Niek Linnenbank writes: > Various Allwinner System on Chip designs contain multiple processors > that can be configured and reset using the generic CPU Configuration > module interface. This commit adds support for the Allwinner CPU > configuration interface which emulates the following feature

[PATCH v6 06/18] hw/arm/allwinner: add CPU Configuration module

2020-03-01 Thread Niek Linnenbank
Various Allwinner System on Chip designs contain multiple processors that can be configured and reset using the generic CPU Configuration module interface. This commit adds support for the Allwinner CPU configuration interface which emulates the following features: * CPU reset * CPU status Sign