Re: [PATCH v6 05/22] target/riscv: Create xl field in env

On Wed, Jan 19, 2022 at 1:36 PM LIU Zhiwei wrote: > > > On 2022/1/19 上午11:24, Alistair Francis wrote: > > On Thu, Jan 13, 2022 at 9:50 PM LIU Zhiwei wrote: > >> Signed-off-by: LIU Zhiwei > > I'm not clear on why this is better? > > Current xlen has been used in helper functions and many other pl

Re: [PATCH v6 05/22] target/riscv: Create xl field in env

On 2022/1/19 上午11:24, Alistair Francis wrote: On Thu, Jan 13, 2022 at 9:50 PM LIU Zhiwei wrote: Signed-off-by: LIU Zhiwei I'm not clear on why this is better? Current xlen has been used in helper functions and many other places.  The computation of current xlen  is not so trivial, so tha

Re: [PATCH v6 05/22] target/riscv: Create xl field in env

On Thu, Jan 13, 2022 at 9:50 PM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei I'm not clear on why this is better? Alistair > --- > target/riscv/cpu.c| 1 + > target/riscv/cpu.h| 31 +++ > target/riscv/cpu_helper.c | 34 ++

[PATCH v6 05/22] target/riscv: Create xl field in env

Signed-off-by: LIU Zhiwei --- target/riscv/cpu.c| 1 + target/riscv/cpu.h| 31 +++ target/riscv/cpu_helper.c | 34 ++ target/riscv/csr.c| 2 ++ target/riscv/machine.c| 10 ++ 5 files changed, 46 inse