Re: [PATCH v6 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-07 Thread Sergio Lopez
Stefano Garzarella writes: > On Fri, Oct 04, 2019 at 11:37:45AM +0200, Sergio Lopez wrote: >> Move x86 functions that will be shared between PC and non-PC machine >> types to x86.c, along with their helpers. >> >> Signed-off-by: Sergio Lopez >> --- >> include/hw/i386/pc.h | 1 - >> include

Re: [PATCH v6 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-04 Thread Stefano Garzarella
On Fri, Oct 04, 2019 at 11:37:45AM +0200, Sergio Lopez wrote: > Move x86 functions that will be shared between PC and non-PC machine > types to x86.c, along with their helpers. > > Signed-off-by: Sergio Lopez > --- > include/hw/i386/pc.h | 1 - > include/hw/i386/x86.h | 35 +++ > hw/i386/pc.

Re: [PATCH v6 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-04 Thread Stefano Garzarella
On Fri, Oct 04, 2019 at 11:37:45AM +0200, Sergio Lopez wrote: > Move x86 functions that will be shared between PC and non-PC machine > types to x86.c, along with their helpers. > > Signed-off-by: Sergio Lopez > --- > include/hw/i386/pc.h | 1 - > include/hw/i386/x86.h | 35 +++ > hw/i386/pc.

Re: [PATCH v6 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-04 Thread Philippe Mathieu-Daudé
On 10/4/19 11:37 AM, Sergio Lopez wrote: Move x86 functions that will be shared between PC and non-PC machine types to x86.c, along with their helpers. Signed-off-by: Sergio Lopez Again: Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h |

[PATCH v6 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-04 Thread Sergio Lopez
Move x86 functions that will be shared between PC and non-PC machine types to x86.c, along with their helpers. Signed-off-by: Sergio Lopez --- include/hw/i386/pc.h | 1 - include/hw/i386/x86.h | 35 +++ hw/i386/pc.c | 582 +-- hw/i386/pc_piix.c |