Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-05 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Mar 04, 2024 at 09:04:51PM +, Daniel P. Berrangé wrote: >> On Mon, Mar 04, 2024 at 05:15:05PM -0300, Fabiano Rosas wrote: >> > Peter Xu writes: >> > >> > > On Mon, Mar 04, 2024 at 08:53:24PM +0800, Peter Xu wrote: >> > >> On Mon, Mar 04, 2024 at 12:42:25PM +,

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Peter Xu
On Mon, Mar 04, 2024 at 09:04:51PM +, Daniel P. Berrangé wrote: > On Mon, Mar 04, 2024 at 05:15:05PM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Mon, Mar 04, 2024 at 08:53:24PM +0800, Peter Xu wrote: > > >> On Mon, Mar 04, 2024 at 12:42:25PM +, Daniel P. Berrangé wrote:

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Daniel P . Berrangé
On Mon, Mar 04, 2024 at 05:15:05PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Mar 04, 2024 at 08:53:24PM +0800, Peter Xu wrote: > >> On Mon, Mar 04, 2024 at 12:42:25PM +, Daniel P. Berrangé wrote: > >> > On Mon, Mar 04, 2024 at 08:35:36PM +0800, Peter Xu wrote: > >> > > Fabi

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Mar 04, 2024 at 08:53:24PM +0800, Peter Xu wrote: >> On Mon, Mar 04, 2024 at 12:42:25PM +, Daniel P. Berrangé wrote: >> > On Mon, Mar 04, 2024 at 08:35:36PM +0800, Peter Xu wrote: >> > > Fabiano, >> > > >> > > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Peter Xu
On Mon, Mar 04, 2024 at 10:09:25AM -0300, Fabiano Rosas wrote: > Perhaps if we move the fsync to the same spot as the multifd thread sync > instead of having a big one at the end? Not sure how that looks with > concurrency in the mix. Can try, but I think the bottleneck should normally be on the b

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Peter Xu
On Mon, Mar 04, 2024 at 08:53:24PM +0800, Peter Xu wrote: > On Mon, Mar 04, 2024 at 12:42:25PM +, Daniel P. Berrangé wrote: > > On Mon, Mar 04, 2024 at 08:35:36PM +0800, Peter Xu wrote: > > > Fabiano, > > > > > > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > > > > => guest:

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Mon, Mar 04, 2024 at 08:35:36PM +0800, Peter Xu wrote: >> Fabiano, >> >> On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: >> > => guest: 128 GB RAM - 120 GB dirty - 1 vcpu in tight loop dirtying memory >> >> I'm curious normally how much time does i

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Peter Xu
On Mon, Mar 04, 2024 at 12:42:25PM +, Daniel P. Berrangé wrote: > On Mon, Mar 04, 2024 at 08:35:36PM +0800, Peter Xu wrote: > > Fabiano, > > > > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > > > => guest: 128 GB RAM - 120 GB dirty - 1 vcpu in tight loop dirtying memory > >

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Daniel P . Berrangé
On Mon, Mar 04, 2024 at 08:35:36PM +0800, Peter Xu wrote: > Fabiano, > > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > > => guest: 128 GB RAM - 120 GB dirty - 1 vcpu in tight loop dirtying memory > > I'm curious normally how much time does it take to do the final fdatasync() >

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-04 Thread Peter Xu
Fabiano, On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > => guest: 128 GB RAM - 120 GB dirty - 1 vcpu in tight loop dirtying memory I'm curious normally how much time does it take to do the final fdatasync() for you when you did this test. I finally got a relatively large system

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-01 Thread Peter Xu
On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > Based-on: 74aa0fb297 (migration: options incompatible with cpr) # > peterx/migration-next > > Hi, > > In this v6: > > - Minor fixes to 17/23 and 19/23 Thanks both for confirming, queued now. -- Peter Xu

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-01 Thread Daniel P . Berrangé
On Fri, Mar 01, 2024 at 09:50:32AM +0800, Peter Xu wrote: > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > > Based-on: 74aa0fb297 (migration: options incompatible with cpr) # > > peterx/migration-next > > > > Hi, > > > > In this v6: > > > > - Minor fixes to 17/23 and 19/23 >

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-02-29 Thread Markus Armbruster
Peter Xu writes: > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: >> Based-on: 74aa0fb297 (migration: options incompatible with cpr) # >> peterx/migration-next >> >> Hi, >> >> In this v6: >> >> - Minor fixes to 17/23 and 19/23 > > The whole set looks good to me now. I plan to

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > Based-on: 74aa0fb297 (migration: options incompatible with cpr) # > peterx/migration-next > > Hi, > > In this v6: > > - Minor fixes to 17/23 and 19/23 The whole set looks good to me now. I plan to queue it before the direct-io s

[PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-02-29 Thread Fabiano Rosas
Based-on: 74aa0fb297 (migration: options incompatible with cpr) # peterx/migration-next Hi, In this v6: - Minor fixes to 17/23 and 19/23 CI run: https://gitlab.com/farosas/qemu/-/pipelines/1195796010 Series structure This series enables mapped-ram in steps: 0) Cleanups