Eric Blake writes:
> On 12/5/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote:
>
@@ -918,27 +917,26 @@ static void device_set_realized(Object *obj, bool
value, Error **errp)
}
} else if (!value && dev->realized) {
-Error **local_errp = NULL;
>>>
06.12.2019 11:26, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 12/5/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote:
>>
> @@ -918,27 +917,26 @@ static void device_set_realized(Object *obj, bool
> value, Error **errp)
>}
>} else if (!value && dev->r
On 12/5/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote:
@@ -918,27 +917,26 @@ static void device_set_realized(Object *obj, bool value,
Error **errp)
}
} else if (!value && dev->realized) {
-Error **local_errp = NULL;
+/* We want local_err to track only the
29.11.2019 9:07, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy writes:
>
>> Rename Error ** parameter in check_only_migratable to common errp.
>>
>> In device_set_realized:
>>
>> - Move "if (local_err != NULL)" closer to error setters.
>>
>> - Drop 'Error **local_errp': it doesn't s
Vladimir Sementsov-Ogievskiy writes:
> Rename Error ** parameter in check_only_migratable to common errp.
>
> In device_set_realized:
>
> - Move "if (local_err != NULL)" closer to error setters.
>
> - Drop 'Error **local_errp': it doesn't save any LoCs, but it's very
>unusual.
>
> Signed-of
Rename Error ** parameter in check_only_migratable to common errp.
In device_set_realized:
- Move "if (local_err != NULL)" closer to error setters.
- Drop 'Error **local_errp': it doesn't save any LoCs, but it's very
unusual.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric B
