Re: [PATCH v5 5/5] dump: Add create_win_dump() stub for non-x86 targets

2023-02-25 Thread Philippe Mathieu-Daudé
On 24/2/23 22:10, Richard Henderson wrote: On 2/23/23 21:38, Philippe Mathieu-Daudé wrote: -specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo]) +softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo]) You can remove the when: as well, yes?

Re: [PATCH v5 5/5] dump: Add create_win_dump() stub for non-x86 targets

2023-02-24 Thread Richard Henderson
On 2/23/23 21:38, Philippe Mathieu-Daudé wrote: -specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo]) +softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo]) You can remove the when: as well, yes? r~

Re: [PATCH v5 5/5] dump: Add create_win_dump() stub for non-x86 targets

2023-02-23 Thread Thomas Huth
On 24/02/2023 08.38, Philippe Mathieu-Daudé wrote: Implement the non-x86 create_win_dump(). We can remove the last TARGET_X86_64 #ifdef'ry in dump.c, which thus becomes target-independent. Update meson accordingly. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe

[PATCH v5 5/5] dump: Add create_win_dump() stub for non-x86 targets

2023-02-23 Thread Philippe Mathieu-Daudé
Implement the non-x86 create_win_dump(). We can remove the last TARGET_X86_64 #ifdef'ry in dump.c, which thus becomes target-independent. Update meson accordingly. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- dump/dump.c | 2 -- dump/me