Re: [PATCH v5 3/4] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Claudio Fontana
On 9/23/22 17:28, Philippe Mathieu-Daudé wrote: > On 23/9/22 16:51, Claudio Fontana wrote: >> improve error handling during module load, by changing: >> >> bool module_load(const char *prefix, const char *lib_name); >> void module_load_qom(const char *type); >> >> to: >> >> int module_load(const ch

Re: [PATCH v5 3/4] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Claudio Fontana
On 9/23/22 17:51, Daniel P. Berrangé wrote: > On Fri, Sep 23, 2022 at 04:51:30PM +0200, Claudio Fontana wrote: >> improve error handling during module load, by changing: >> >> bool module_load(const char *prefix, const char *lib_name); >> void module_load_qom(const char *type); >> >> to: >> >> int

Re: [PATCH v5 3/4] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Daniel P . Berrangé
On Fri, Sep 23, 2022 at 04:51:30PM +0200, Claudio Fontana wrote: > improve error handling during module load, by changing: > > bool module_load(const char *prefix, const char *lib_name); > void module_load_qom(const char *type); > > to: > > int module_load(const char *prefix, const char *name, E

Re: [PATCH v5 3/4] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Philippe Mathieu-Daudé via
On 23/9/22 16:51, Claudio Fontana wrote: improve error handling during module load, by changing: bool module_load(const char *prefix, const char *lib_name); void module_load_qom(const char *type); to: int module_load(const char *prefix, const char *name, Error **errp); int module_load_qom(cons

[PATCH v5 3/4] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Claudio Fontana
improve error handling during module load, by changing: bool module_load(const char *prefix, const char *lib_name); void module_load_qom(const char *type); to: int module_load(const char *prefix, const char *name, Error **errp); int module_load_qom(const char *type, Error **errp); where the ret