Re: [PATCH v5 3/3] target/ppc: support single stepping with KVM HV

2019-12-13 Thread Fabiano Rosas
David Gibson writes: Hi, thanks for the review! My comments below: > On Wed, Dec 11, 2019 at 04:10:13PM -0300, Fabiano Rosas wrote: >> The hardware singlestep mechanism in POWER works via a Trace Interrupt >> (0xd00) that happens after any instruction executes, whenever MSR_SE = >> 1 (PowerISA S

Re: [PATCH v5 3/3] target/ppc: support single stepping with KVM HV

2019-12-11 Thread David Gibson
On Wed, Dec 11, 2019 at 04:10:13PM -0300, Fabiano Rosas wrote: > The hardware singlestep mechanism in POWER works via a Trace Interrupt > (0xd00) that happens after any instruction executes, whenever MSR_SE = > 1 (PowerISA Section 6.5.15 - Trace Interrupt). > > However, with kvm_hv, the Trace Inte

[PATCH v5 3/3] target/ppc: support single stepping with KVM HV

2019-12-11 Thread Fabiano Rosas
The hardware singlestep mechanism in POWER works via a Trace Interrupt (0xd00) that happens after any instruction executes, whenever MSR_SE = 1 (PowerISA Section 6.5.15 - Trace Interrupt). However, with kvm_hv, the Trace Interrupt happens inside the guest and KVM has no visibility of it. Therefore