Re: [PATCH v5 21/24] target/m68k: Implement packed decimal real loads and stores

2025-05-11 Thread Richard Henderson
On 5/10/25 09:36, Andreas Schwab wrote: On Mai 07 2025, Richard Henderson wrote: +/* Convert the 3 digit decimal exponent to binary. */ +exp = ((hi >> 24) & 0xf) ++ ((hi >> 20) & 0xf) * 10 ++ ((hi >> 16) & 0xf) * 100; This is backwards. An exponent of 123 is stored as

Re: [PATCH v5 21/24] target/m68k: Implement packed decimal real loads and stores

2025-05-10 Thread Andreas Schwab
On Mai 07 2025, Richard Henderson wrote: > +/* Convert the 3 digit decimal exponent to binary. */ > +exp = ((hi >> 24) & 0xf) > ++ ((hi >> 20) & 0xf) * 10 > ++ ((hi >> 16) & 0xf) * 100; This is backwards. An exponent of 123 is stored as 0x0123, not 0x0321. > +