Re: [PATCH v5 2/7] plugins: save value during memory accesses

2024-07-06 Thread Pierrick Bouvier
On 7/5/24 09:34, Richard Henderson wrote: On 7/4/24 17:34, Pierrick Bouvier wrote: +static void +plugin_gen_mem_callbacks_i32(TCGv_i32 val, + TCGv_i64 copy_addr, TCGTemp *orig_addr, + MemOpIdx oi, enum qemu_plugin_mem_rw rw) +{ +#ifdef CONF

Re: [PATCH v5 2/7] plugins: save value during memory accesses

2024-07-05 Thread Richard Henderson
On 7/4/24 17:34, Pierrick Bouvier wrote: +static void +plugin_gen_mem_callbacks_i32(TCGv_i32 val, + TCGv_i64 copy_addr, TCGTemp *orig_addr, + MemOpIdx oi, enum qemu_plugin_mem_rw rw) +{ +#ifdef CONFIG_PLUGIN +if (tcg_ctx->plugin_insn !=

[PATCH v5 2/7] plugins: save value during memory accesses

2024-07-04 Thread Pierrick Bouvier
Different code paths handle memory accesses: - tcg generated code - load/store helpers - atomic helpers This value is saved in cpu->neg.plugin_mem_value_{high,low}. Values are written only for accessed word size (upper bits are not set). Atomic operations are doing read/write at the same time, so