Re: [PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-21 Thread Nir Soffer
On Thu, May 21, 2020 at 6:09 PM Vladimir Sementsov-Ogievskiy wrote: > > 21.05.2020 16:29, Nir Soffer wrote: > > On Thu, May 21, 2020 at 2:40 PM Vladimir Sementsov-Ogievskiy > > wrote: > >> > >> 21.05.2020 02:00, Nir Soffer wrote: > >>> On Thu, May 21, 2020 at 1:01 AM Eric Blake wrote: > > >

Re: [PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
21.05.2020 16:29, Nir Soffer wrote: On Thu, May 21, 2020 at 2:40 PM Vladimir Sementsov-Ogievskiy wrote: 21.05.2020 02:00, Nir Soffer wrote: On Thu, May 21, 2020 at 1:01 AM Eric Blake wrote: It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such met

Re: [PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-21 Thread Nir Soffer
On Thu, May 21, 2020 at 2:40 PM Vladimir Sementsov-Ogievskiy wrote: > > 21.05.2020 02:00, Nir Soffer wrote: > > On Thu, May 21, 2020 at 1:01 AM Eric Blake wrote: > >> > >> It's useful to know how much space can be occupied by qcow2 persistent > >> bitmaps, even though such metadata is unrelated t

Re: [PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-21 Thread Eric Blake
On 5/21/20 8:17 AM, Nir Soffer wrote: I'm ok with both options, can we have only one? That was the crux of the conversation after v3, where we were trying to figure out what interface you actually needed. I implemented both to show the difference, but if you want only one, then my preference

Re: [PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-21 Thread Nir Soffer
On Thu, May 21, 2020 at 4:08 PM Eric Blake wrote: > > On 5/20/20 6:00 PM, Nir Soffer wrote: > > >> > >> On the command-line side, 'qemu-img measure' gains a new --bitmaps > >> flag. When present, the bitmap size is rolled into the two existing > >> measures (or errors if either the source image o

Re: [PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-21 Thread Eric Blake
On 5/20/20 6:00 PM, Nir Soffer wrote: On the command-line side, 'qemu-img measure' gains a new --bitmaps flag. When present, the bitmap size is rolled into the two existing measures (or errors if either the source image or destination format lacks bitmaps); when absent, there is never an error

Re: [PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
21.05.2020 02:00, Nir Soffer wrote: On Thu, May 21, 2020 at 1:01 AM Eric Blake wrote: It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional QMP field, present when me

Re: [PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-20 Thread Nir Soffer
On Thu, May 21, 2020 at 1:01 AM Eric Blake wrote: > > It's useful to know how much space can be occupied by qcow2 persistent > bitmaps, even though such metadata is unrelated to the guest-visible > data. Report this value as an additional QMP field, present when > measuring an existing image and

[PATCH v5 2/5] qcow2: Expose bitmaps' size during measure

2020-05-20 Thread Eric Blake
It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional QMP field, present when measuring an existing image and output format that both support bitmaps. Update iotest 178 a