Re: [PATCH v5 2/4] target/ppc: added ifdefs around TCG-only code

2021-05-27 Thread David Gibson
On Wed, May 26, 2021 at 02:24:32PM -0300, Bruno Piazera Larsen wrote: > > On 25/05/2021 10:02, Philippe Mathieu-Daudé wrote: > > On 5/25/21 1:53 PM, Bruno Larsen (billionai) wrote: > > > excp_helper.c, mmu-hash64.c and mmu_helper.c have some function > > > declarations that are TCG-only, and could

Re: [PATCH v5 2/4] target/ppc: added ifdefs around TCG-only code

2021-05-26 Thread Bruno Piazera Larsen
On 25/05/2021 10:02, Philippe Mathieu-Daudé wrote: On 5/25/21 1:53 PM, Bruno Larsen (billionai) wrote: excp_helper.c, mmu-hash64.c and mmu_helper.c have some function declarations that are TCG-only, and couldn't be easily moved to a TCG only file, so ifdefs were added around them. We also need

Re: [PATCH v5 2/4] target/ppc: added ifdefs around TCG-only code

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/25/21 1:53 PM, Bruno Larsen (billionai) wrote: > excp_helper.c, mmu-hash64.c and mmu_helper.c have some function > declarations that are TCG-only, and couldn't be easily moved to a > TCG only file, so ifdefs were added around them. > > We also needed ifdefs around some header files because he

[PATCH v5 2/4] target/ppc: added ifdefs around TCG-only code

2021-05-25 Thread Bruno Larsen (billionai)
excp_helper.c, mmu-hash64.c and mmu_helper.c have some function declarations that are TCG-only, and couldn't be easily moved to a TCG only file, so ifdefs were added around them. We also needed ifdefs around some header files because helper-proto.h includes trace/generated-helpers.h, which is neve