Re: [PATCH v5 2/3] kvm-all: Introduce kvm_set_singlestep

2019-12-13 Thread Fabiano Rosas
David Gibson writes: > On Wed, Dec 11, 2019 at 04:10:12PM -0300, Fabiano Rosas wrote: >> For single stepping (via KVM) of a guest vcpu to work, KVM needs not >> only to support the SET_GUEST_DEBUG ioctl but to also recognize the >> KVM_GUESTDBG_SINGLESTEP bit in the control field of the >> kvm_gu

Re: [PATCH v5 2/3] kvm-all: Introduce kvm_set_singlestep

2019-12-11 Thread David Gibson
On Wed, Dec 11, 2019 at 04:10:12PM -0300, Fabiano Rosas wrote: > For single stepping (via KVM) of a guest vcpu to work, KVM needs not > only to support the SET_GUEST_DEBUG ioctl but to also recognize the > KVM_GUESTDBG_SINGLESTEP bit in the control field of the > kvm_guest_debug struct. > > This p

[PATCH v5 2/3] kvm-all: Introduce kvm_set_singlestep

2019-12-11 Thread Fabiano Rosas
For single stepping (via KVM) of a guest vcpu to work, KVM needs not only to support the SET_GUEST_DEBUG ioctl but to also recognize the KVM_GUESTDBG_SINGLESTEP bit in the control field of the kvm_guest_debug struct. This patch adds support for querying the single step capability so that QEMU can