Re: [PATCH v5 17/23] migration/multifd: Add outgoing QIOChannelFile support

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 02:34:13PM +, Daniel P. Berrangé wrote: > On Thu, Feb 29, 2024 at 11:27:44AM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Thu, Feb 29, 2024 at 10:44:21AM +0800, Peter Xu wrote: > > >> On Wed, Feb 28, 2024 at 12:21:21PM -0300, Fabiano Rosas wrote: > > >

Re: [PATCH v5 17/23] migration/multifd: Add outgoing QIOChannelFile support

2024-02-29 Thread Daniel P . Berrangé
On Thu, Feb 29, 2024 at 11:27:44AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Thu, Feb 29, 2024 at 10:44:21AM +0800, Peter Xu wrote: > >> On Wed, Feb 28, 2024 at 12:21:21PM -0300, Fabiano Rosas wrote: > >> > Allow multifd to open file-backed channels. This will be used when > >> > en

Re: [PATCH v5 17/23] migration/multifd: Add outgoing QIOChannelFile support

2024-02-29 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Feb 29, 2024 at 10:44:21AM +0800, Peter Xu wrote: >> On Wed, Feb 28, 2024 at 12:21:21PM -0300, Fabiano Rosas wrote: >> > Allow multifd to open file-backed channels. This will be used when >> > enabling the mapped-ram migration stream format which expects a >> > seekable

Re: [PATCH v5 17/23] migration/multifd: Add outgoing QIOChannelFile support

2024-02-28 Thread Peter Xu
On Thu, Feb 29, 2024 at 10:44:21AM +0800, Peter Xu wrote: > On Wed, Feb 28, 2024 at 12:21:21PM -0300, Fabiano Rosas wrote: > > Allow multifd to open file-backed channels. This will be used when > > enabling the mapped-ram migration stream format which expects a > > seekable transport. > > > > The

Re: [PATCH v5 17/23] migration/multifd: Add outgoing QIOChannelFile support

2024-02-28 Thread Peter Xu
On Wed, Feb 28, 2024 at 12:21:21PM -0300, Fabiano Rosas wrote: > Allow multifd to open file-backed channels. This will be used when > enabling the mapped-ram migration stream format which expects a > seekable transport. > > The QIOChannel read and write methods will use the preadv/pwritev > versio

[PATCH v5 17/23] migration/multifd: Add outgoing QIOChannelFile support

2024-02-28 Thread Fabiano Rosas
Allow multifd to open file-backed channels. This will be used when enabling the mapped-ram migration stream format which expects a seekable transport. The QIOChannel read and write methods will use the preadv/pwritev versions which don't update the file offset at each call so we can reuse the fd w