Re: [PATCH v5 12/21] virtio-net: Always set populate_hash

2023-10-27 Thread Akihiko Odaki
On 2023/10/27 16:08, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:10 PM Akihiko Odaki wrote: The member is not cleared during reset so may have a stale value. Nit: I guess it should be "always unset populate_hash"? I meant populate_hash should be always set to either of true or false in v

Re: [PATCH v5 12/21] virtio-net: Always set populate_hash

2023-10-27 Thread Jason Wang
On Tue, Oct 17, 2023 at 12:10 PM Akihiko Odaki wrote: > > The member is not cleared during reset so may have a stale value. Nit: I guess it should be "always unset populate_hash"? Thanks > > Signed-off-by: Akihiko Odaki > --- > hw/net/virtio-net.c | 1 + > 1 file changed, 1 insertion(+) > > d

[PATCH v5 12/21] virtio-net: Always set populate_hash

2023-10-16 Thread Akihiko Odaki
The member is not cleared during reset so may have a stale value. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 20feb20bb1..6eb206f297 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-n