Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-12-02 Thread Peter Maydell
On Mon, 2 Dec 2019 at 13:05, Damien Hedde wrote: > > I don't know why it has been implemented like this but right now the > raspi_init() does the following during machine creation: > | bus = qdev_get_child_bus(DEVICE(&s->soc), "sd-bus"); > | [...] > | carddev = qdev_create(bus, TYPE_SD_CARD); > wh

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-12-02 Thread Damien Hedde
On 12/2/19 1:33 PM, Peter Maydell wrote: > On Mon, 2 Dec 2019 at 12:27, Damien Hedde wrote: >> >> >> >> On 11/29/19 8:05 PM, Peter Maydell wrote: >>> On Fri, 18 Oct 2019 at 16:07, Damien Hedde >>> wrote: @@ -97,6 +101,7 @@ static void gpfsel_set(BCM2835GpioState *s, uint8_t reg, ui

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-12-02 Thread Peter Maydell
On Mon, 2 Dec 2019 at 12:27, Damien Hedde wrote: > > > > On 11/29/19 8:05 PM, Peter Maydell wrote: > > On Fri, 18 Oct 2019 at 16:07, Damien Hedde > > wrote: > >> @@ -97,6 +101,7 @@ static void gpfsel_set(BCM2835GpioState *s, uint8_t > >> reg, uint32_t value) > >> && (s->fsel[53] ==

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-12-02 Thread Damien Hedde
On 11/29/19 8:05 PM, Peter Maydell wrote: > On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: >> >> Split gpfsel_set() in 2 so that the sdbus reparenting is done >> in a dedicated function. >> >> Signed-off-by: Damien Hedde >> --- >> Cc: Peter Maydell >> Cc: Andrew Baumann >> Cc: Philippe Ma

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Split gpfsel_set() in 2 so that the sdbus reparenting is done > in a dedicated function. > > Signed-off-by: Damien Hedde > --- > Cc: Peter Maydell > Cc: Andrew Baumann > Cc: Philippe Mathieu-Daudé > Cc: qemu-...@nongnu.org > --- > hw/gpio/

[PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-10-18 Thread Damien Hedde
Split gpfsel_set() in 2 so that the sdbus reparenting is done in a dedicated function. Signed-off-by: Damien Hedde --- Cc: Peter Maydell Cc: Andrew Baumann Cc: Philippe Mathieu-Daudé Cc: qemu-...@nongnu.org --- hw/gpio/bcm2835_gpio.c | 16 1 file changed, 12 insertions(+), 4