Re: [PATCH v5 10/10] ram-block-attribute: Add more error handling during state changes

2025-05-27 Thread David Hildenbrand
If something went wrong... well, on my AMD machine this usually means the fw is really unhappy and recovery is hardly possible and the machine needs reboot. Probably stopping the VM would make more sense for now (or stop the device so the user could save work from the VM, dunno). My current

Re: [PATCH v5 10/10] ram-block-attribute: Add more error handling during state changes

2025-05-27 Thread Chenyi Qiang
On 5/27/2025 5:11 PM, Alexey Kardashevskiy wrote: > > > On 20/5/25 20:28, Chenyi Qiang wrote: >> The current error handling is simple with the following assumption: >> - QEMU will quit instead of resuming the guest if kvm_convert_memory() >>    fails, thus no need to do rollback. >> - The conv

Re: [PATCH v5 10/10] ram-block-attribute: Add more error handling during state changes

2025-05-27 Thread Alexey Kardashevskiy
On 20/5/25 20:28, Chenyi Qiang wrote: The current error handling is simple with the following assumption: - QEMU will quit instead of resuming the guest if kvm_convert_memory() fails, thus no need to do rollback. - The convert range is required to be in the desired state. It is not allow

Re: [PATCH v5 10/10] ram-block-attribute: Add more error handling during state changes

2025-05-26 Thread Chenyi Qiang
On 5/26/2025 8:10 PM, David Hildenbrand wrote: > On 26.05.25 12:19, Chenyi Qiang wrote: >> >> >> On 5/26/2025 5:17 PM, David Hildenbrand wrote: >>> On 20.05.25 12:28, Chenyi Qiang wrote: The current error handling is simple with the following assumption: - QEMU will quit instead of res

Re: [PATCH v5 10/10] ram-block-attribute: Add more error handling during state changes

2025-05-26 Thread David Hildenbrand
On 26.05.25 12:19, Chenyi Qiang wrote: On 5/26/2025 5:17 PM, David Hildenbrand wrote: On 20.05.25 12:28, Chenyi Qiang wrote: The current error handling is simple with the following assumption: - QEMU will quit instead of resuming the guest if kvm_convert_memory()    fails, thus no need to do

Re: [PATCH v5 10/10] ram-block-attribute: Add more error handling during state changes

2025-05-26 Thread David Hildenbrand
On 20.05.25 12:28, Chenyi Qiang wrote: The current error handling is simple with the following assumption: - QEMU will quit instead of resuming the guest if kvm_convert_memory() fails, thus no need to do rollback. - The convert range is required to be in the desired state. It is not allowed

Re: [PATCH v5 10/10] ram-block-attribute: Add more error handling during state changes

2025-05-26 Thread Chenyi Qiang
On 5/26/2025 5:17 PM, David Hildenbrand wrote: > On 20.05.25 12:28, Chenyi Qiang wrote: >> The current error handling is simple with the following assumption: >> - QEMU will quit instead of resuming the guest if kvm_convert_memory() >>    fails, thus no need to do rollback. >> - The convert rang

[PATCH v5 10/10] ram-block-attribute: Add more error handling during state changes

2025-05-20 Thread Chenyi Qiang
The current error handling is simple with the following assumption: - QEMU will quit instead of resuming the guest if kvm_convert_memory() fails, thus no need to do rollback. - The convert range is required to be in the desired state. It is not allowed to handle the mixture case. - The conversi