Re: [PATCH v5 10/10] migration: introduce snapshot-{save,load,delete} QMP commands

2020-10-06 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: > > savevm, loadvm and delvm are some of the few HMP commands that have never > > been converted to use QMP. The reasons for the lack of conversion are > > that they blocked execution of the event thread, and

Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands

2020-10-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Oct 05, 2020 at 09:26:54AM +0200, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: >> > >> > Do we have a query- command handy to easily learn which snapshot names >> > are even available to attempt deleti

Re: [PATCH v5 10/10] migration: introduce snapshot-{save,load,delete} QMP commands

2020-10-05 Thread Daniel P . Berrangé
On Fri, Oct 02, 2020 at 02:46:07PM -0500, Eric Blake wrote: > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: > > savevm, loadvm and delvm are some of the few HMP commands that have never > > been converted to use QMP. The reasons for the lack of conversion are > > that they blocked execution of the

Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands

2020-10-05 Thread Daniel P . Berrangé
On Mon, Oct 05, 2020 at 09:26:54AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: > > > > Do we have a query- command handy to easily learn which snapshot names > > are even available to attempt deletion on? If not, that's worth a > > se

Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands

2020-10-05 Thread Markus Armbruster
Eric Blake writes: > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: >> savevm, loadvm and delvm are some of the few HMP commands that have never >> been converted to use QMP. The reasons for the lack of conversion are >> that they blocked execution of the event thread, and the semantics >> around

Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands

2020-10-02 Thread Eric Blake
On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: > savevm, loadvm and delvm are some of the few HMP commands that have never > been converted to use QMP. The reasons for the lack of conversion are > that they blocked execution of the event thread, and the semantics > around choice of disks were ill-d

[PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands

2020-10-02 Thread Daniel P . Berrangé
savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The reasons for the lack of conversion are that they blocked execution of the event thread, and the semantics around choice of disks were ill-defined. Despite this downside, however, libvirt and ap