Re: [PATCH v5 10/10] KVM: Dirty ring support

2021-03-22 Thread Keqian Zhu
On 2021/3/23 2:52, Peter Xu wrote: > On Mon, Mar 22, 2021 at 09:37:19PM +0800, Keqian Zhu wrote: >>> +/* Should be with all slots_lock held for the address spaces. */ >>> +static void kvm_dirty_ring_mark_page(KVMState *s, uint32_t as_id, >>> + uint32_t slot_id

Re: [PATCH v5 10/10] KVM: Dirty ring support

2021-03-22 Thread Peter Xu
On Mon, Mar 22, 2021 at 09:37:19PM +0800, Keqian Zhu wrote: > > +/* Should be with all slots_lock held for the address spaces. */ > > +static void kvm_dirty_ring_mark_page(KVMState *s, uint32_t as_id, > > + uint32_t slot_id, uint64_t offset) > > +{ > > +KVMMe

Re: [PATCH v5 10/10] KVM: Dirty ring support

2021-03-22 Thread Keqian Zhu
On 2021/3/11 4:33, Peter Xu wrote: > KVM dirty ring is a new interface to pass over dirty bits from kernel to the > userspace. Instead of using a bitmap for each memory region, the dirty ring > contains an array of dirtied GPAs to fetch (in the form of offset in slots). > For each vcpu there wi

[PATCH v5 10/10] KVM: Dirty ring support

2021-03-10 Thread Peter Xu
KVM dirty ring is a new interface to pass over dirty bits from kernel to the userspace. Instead of using a bitmap for each memory region, the dirty ring contains an array of dirtied GPAs to fetch (in the form of offset in slots). For each vcpu there will be one dirty ring that binds to it. kvm_di