Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-22 Thread Beata Michalska
Hi Andrew, On Tue, 22 Oct 2019 at 14:43, Andrew Jones wrote: > > On Mon, Oct 21, 2019 at 04:07:14PM +0100, Beata Michalska wrote: > > Indeed, the patch got bit messed-up. Apologies for that as well. > > I have been testing manually but I did try the test you have provided > > and yes it fails - t

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-22 Thread Andrew Jones
On Mon, Oct 21, 2019 at 04:07:14PM +0100, Beata Michalska wrote: > Indeed, the patch got bit messed-up. Apologies for that as well. > I have been testing manually but I did try the test you have provided > and yes it fails - there is a slight problem with the case when qdict_in > is empty,but this

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-21 Thread Beata Michalska
On Wed, 16 Oct 2019 at 17:16, Andrew Jones wrote: > > On Wed, Oct 16, 2019 at 04:16:57PM +0100, Beata Michalska wrote: > > On Wed, 16 Oct 2019 at 14:50, Andrew Jones wrote: > > > > > > On Wed, Oct 16, 2019 at 02:24:50PM +0100, Beata Michalska wrote: > > > > On Tue, 15 Oct 2019 at 12:56, Beata Mic

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-16 Thread Andrew Jones
On Wed, Oct 16, 2019 at 04:16:57PM +0100, Beata Michalska wrote: > On Wed, 16 Oct 2019 at 14:50, Andrew Jones wrote: > > > > On Wed, Oct 16, 2019 at 02:24:50PM +0100, Beata Michalska wrote: > > > On Tue, 15 Oct 2019 at 12:56, Beata Michalska > > > wrote: > > > > > > > > On Tue, 15 Oct 2019 at 11:

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-16 Thread Beata Michalska
On Wed, 16 Oct 2019 at 14:50, Andrew Jones wrote: > > On Wed, Oct 16, 2019 at 02:24:50PM +0100, Beata Michalska wrote: > > On Tue, 15 Oct 2019 at 12:56, Beata Michalska > > wrote: > > > > > > On Tue, 15 Oct 2019 at 11:56, Andrew Jones wrote: > > > > > > > > On Tue, Oct 15, 2019 at 10:59:16AM +01

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-16 Thread Andrew Jones
On Wed, Oct 16, 2019 at 02:24:50PM +0100, Beata Michalska wrote: > On Tue, 15 Oct 2019 at 12:56, Beata Michalska > wrote: > > > > On Tue, 15 Oct 2019 at 11:56, Andrew Jones wrote: > > > > > > On Tue, Oct 15, 2019 at 10:59:16AM +0100, Beata Michalska wrote: > > > > On Tue, 1 Oct 2019 at 14:04, And

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-16 Thread Beata Michalska
On Tue, 15 Oct 2019 at 12:56, Beata Michalska wrote: > > On Tue, 15 Oct 2019 at 11:56, Andrew Jones wrote: > > > > On Tue, Oct 15, 2019 at 10:59:16AM +0100, Beata Michalska wrote: > > > On Tue, 1 Oct 2019 at 14:04, Andrew Jones wrote: > > > > + > > > > +obj = object_new(object_class_get_name

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-15 Thread Beata Michalska
On Tue, 15 Oct 2019 at 11:56, Andrew Jones wrote: > > On Tue, Oct 15, 2019 at 10:59:16AM +0100, Beata Michalska wrote: > > On Tue, 1 Oct 2019 at 14:04, Andrew Jones wrote: > > > + > > > +obj = object_new(object_class_get_name(oc)); > > > + > > > +if (qdict_in) { > > > +Visitor *vi

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-15 Thread Andrew Jones
On Tue, Oct 15, 2019 at 10:59:16AM +0100, Beata Michalska wrote: > On Tue, 1 Oct 2019 at 14:04, Andrew Jones wrote: > > + > > +obj = object_new(object_class_get_name(oc)); > > + > > +if (qdict_in) { > > +Visitor *visitor; > > +Error *err = NULL; > > + > > +visitor =

Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-15 Thread Beata Michalska
On Tue, 1 Oct 2019 at 14:04, Andrew Jones wrote: > > Add support for the query-cpu-model-expansion QMP command to Arm. We > do this selectively, only exposing CPU properties which represent > optional CPU features which the user may want to enable/disable. > Additionally we restrict the list of qu

[PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion

2019-10-01 Thread Andrew Jones
Add support for the query-cpu-model-expansion QMP command to Arm. We do this selectively, only exposing CPU properties which represent optional CPU features which the user may want to enable/disable. Additionally we restrict the list of queryable cpu models to 'max', 'host', or the current type whe