Re: [PATCH v5 1/4] migration: introduce 'background-snapshot' migration capability

2020-12-08 Thread Andrey Gruzdev
On 08.12.2020 18:47, Peter Xu wrote: On Fri, Dec 04, 2020 at 12:31:00PM +0300, Andrey Gruzdev wrote: +static +WriteTrackingSupport migrate_query_write_tracking(void) +{ +static WriteTrackingSupport wt_support = WT_SUPPORT_UNKNOWN; Better to be non-static - consider uncompatible memory can b

Re: [PATCH v5 1/4] migration: introduce 'background-snapshot' migration capability

2020-12-08 Thread Peter Xu
On Fri, Dec 04, 2020 at 12:31:00PM +0300, Andrey Gruzdev wrote: > +static > +WriteTrackingSupport migrate_query_write_tracking(void) > +{ > +static WriteTrackingSupport wt_support = WT_SUPPORT_UNKNOWN; Better to be non-static - consider uncompatible memory can be hot plugged after it's once se

[PATCH v5 1/4] migration: introduce 'background-snapshot' migration capability

2020-12-04 Thread Andrey Gruzdev via
Add new capability to 'qapi/migration.json' schema. Update migrate_caps_check() to validate enabled capability set against introduced one. Perform checks for required kernel features and compatibility with guest memory backends. Signed-off-by: Andrey Gruzdev --- migration/migration.c | 116 +