Re: [PATCH v5 1/4] coreaudio: Improve naming

2025-01-23 Thread Akihiko Odaki
On 2025/01/23 21:28, BALATON Zoltan wrote: On Thu, 23 Jan 2025, Akihiko Odaki wrote: coreaudio had names that are not conforming to QEMU codding style. coreaudioVoiceOut also had some members that are prefixed with redundant words like "output" or "audio". Global names included "out" to tell the

Re: [PATCH v5 1/4] coreaudio: Improve naming

2025-01-23 Thread Akihiko Odaki
On 2025/01/23 21:24, BALATON Zoltan wrote: On Thu, 23 Jan 2025, Akihiko Odaki wrote: coreaudio had names that are not conforming to QEMU codding style. coreaudioVoiceOut also had some members that are prefixed with redundant words like "output" or "audio". Global names included "out" to tell the

Re: [PATCH v5 1/4] coreaudio: Improve naming

2025-01-23 Thread BALATON Zoltan
On Thu, 23 Jan 2025, Akihiko Odaki wrote: coreaudio had names that are not conforming to QEMU codding style. coreaudioVoiceOut also had some members that are prefixed with redundant words like "output" or "audio". Global names included "out" to tell they are specific to output devices, but this r

Re: [PATCH v5 1/4] coreaudio: Improve naming

2025-01-23 Thread BALATON Zoltan
On Thu, 23 Jan 2025, Akihiko Odaki wrote: coreaudio had names that are not conforming to QEMU codding style. coreaudioVoiceOut also had some members that are prefixed with redundant words like "output" or "audio". Global names included "out" to tell they are specific to output devices, but this r

Re: [PATCH v5 1/4] coreaudio: Improve naming

2025-01-23 Thread Philippe Mathieu-Daudé
On 23/1/25 08:18, Akihiko Odaki wrote: coreaudio had names that are not conforming to QEMU codding style. coreaudioVoiceOut also had some members that are prefixed with redundant words like "output" or "audio". Global names included "out" to tell they are specific to output devices, but this rule

[PATCH v5 1/4] coreaudio: Improve naming

2025-01-22 Thread Akihiko Odaki
coreaudio had names that are not conforming to QEMU codding style. coreaudioVoiceOut also had some members that are prefixed with redundant words like "output" or "audio". Global names included "out" to tell they are specific to output devices, but this rule was not completely enforced. The frame s