Re: [PATCH v5 1/1] util/async-teardown: wire up query-command-line-options

2023-03-28 Thread Markus Armbruster
Thomas Huth writes: > On 28/03/2023 07.26, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> I am honestly not a fan of adding a more complex option,.just because >>> query-command-line-options only returns the square holes whereas here we >>> got a round one. >>> >>> Can we imagine anot

Re: [PATCH v5 1/1] util/async-teardown: wire up query-command-line-options

2023-03-28 Thread Thomas Huth
On 28/03/2023 07.26, Markus Armbruster wrote: Paolo Bonzini writes: I am honestly not a fan of adding a more complex option,.just because query-command-line-options only returns the square holes whereas here we got a round one. Can we imagine another functionality that would be added to -tear

Re: [PATCH v5 1/1] util/async-teardown: wire up query-command-line-options

2023-03-27 Thread Markus Armbruster
Paolo Bonzini writes: > I am honestly not a fan of adding a more complex option,.just because > query-command-line-options only returns the square holes whereas here we > got a round one. > > Can we imagine another functionality that would be added to -teardown? If > not, it's not a good design.

Re: [PATCH v5 1/1] util/async-teardown: wire up query-command-line-options

2023-03-27 Thread Paolo Bonzini
I am honestly not a fan of adding a more complex option,.just because query-command-line-options only returns the square holes whereas here we got a round one. Can we imagine another functionality that would be added to -teardown? If not, it's not a good design. If it works, I would add a complete

[PATCH v5 1/1] util/async-teardown: wire up query-command-line-options

2023-03-27 Thread Claudio Imbrenda
Add new -teardown option with an async=on|off parameter. It is visible in the output of query-command-line-options QMP command, so it can be discovered and used by libvirt. The option -async-teardown is now redundant. We'd normally deprecate it and remove it after a grace period, but it was introd