Re: [PATCH v5 09/18] tests/qtest: Use send/recv for socket communication

2022-10-19 Thread Thomas Huth
On 19/10/2022 09.09, Bin Meng wrote: On Wed, Oct 19, 2022 at 12:47 AM Alex Bennée wrote: Bin Meng writes: From: Xuzhou Cheng Socket communication in the libqtest and libqmp codes uses read() and write() which work on any file descriptor on *nix, and sockets in *nix are an example of a fi

Re: [PATCH v5 09/18] tests/qtest: Use send/recv for socket communication

2022-10-19 Thread Bin Meng
On Wed, Oct 19, 2022 at 12:47 AM Alex Bennée wrote: > > > Bin Meng writes: > > > From: Xuzhou Cheng > > > > Socket communication in the libqtest and libqmp codes uses read() > > and write() which work on any file descriptor on *nix, and sockets > > in *nix are an example of a file descriptor. >

Re: [PATCH v5 09/18] tests/qtest: Use send/recv for socket communication

2022-10-18 Thread Daniel P . Berrangé
On Tue, Oct 18, 2022 at 06:09:28PM +0100, Peter Maydell wrote: > On Thu, 6 Oct 2022 at 17:20, Bin Meng wrote: > > > > From: Xuzhou Cheng > > > > Socket communication in the libqtest and libqmp codes uses read() > > and write() which work on any file descriptor on *nix, and sockets > > in *nix are

Re: [PATCH v5 09/18] tests/qtest: Use send/recv for socket communication

2022-10-18 Thread Peter Maydell
On Thu, 6 Oct 2022 at 17:20, Bin Meng wrote: > > From: Xuzhou Cheng > > Socket communication in the libqtest and libqmp codes uses read() > and write() which work on any file descriptor on *nix, and sockets > in *nix are an example of a file descriptor. > > However sockets on Windows do not use *

Re: [PATCH v5 09/18] tests/qtest: Use send/recv for socket communication

2022-10-18 Thread Alex Bennée
Bin Meng writes: > From: Xuzhou Cheng > > Socket communication in the libqtest and libqmp codes uses read() > and write() which work on any file descriptor on *nix, and sockets > in *nix are an example of a file descriptor. > > However sockets on Windows do not use *nix-style file descriptors,

[PATCH v5 09/18] tests/qtest: Use send/recv for socket communication

2022-10-06 Thread Bin Meng
From: Xuzhou Cheng Socket communication in the libqtest and libqmp codes uses read() and write() which work on any file descriptor on *nix, and sockets in *nix are an example of a file descriptor. However sockets on Windows do not use *nix-style file descriptors, so read() and write() cannot be