Re: [PATCH v5 09/10] linux-user/ppc: Fix msr updates for signal handling

2021-03-23 Thread David Gibson
On Tue, Mar 23, 2021 at 12:43:39PM -0600, Richard Henderson wrote: > In save_user_regs, there are two bugs where we OR in a bit number > instead of the bit, clobbering the low bits of MSR. However: > > The MSR_VR and MSR_SPE bits control the availability of the insns. > If the bits were not alrea

[PATCH v5 09/10] linux-user/ppc: Fix msr updates for signal handling

2021-03-23 Thread Richard Henderson
In save_user_regs, there are two bugs where we OR in a bit number instead of the bit, clobbering the low bits of MSR. However: The MSR_VR and MSR_SPE bits control the availability of the insns. If the bits were not already set in MSR, then any attempt to access those registers would result in SIG