Re: [PATCH v5 08/31] accel/tcg: Implement AccelOpsClass::has_work() as stub

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/21/21 00:01, Richard Henderson wrote: On 9/20/21 2:44 PM, Philippe Mathieu-Daudé wrote: +static bool tcg_cpu_has_work(CPUState *cpu) +{ +    CPUClass *cc = CPU_GET_CLASS(cpu); + +    g_assert(cc->tcg_ops->has_work); +    return cc->tcg_ops->has_work(cpu); +} Now, you're expecting cc->has_

Re: [PATCH v5 08/31] accel/tcg: Implement AccelOpsClass::has_work() as stub

2021-09-20 Thread Richard Henderson
On 9/20/21 2:44 PM, Philippe Mathieu-Daudé wrote: +static bool tcg_cpu_has_work(CPUState *cpu) +{ +CPUClass *cc = CPU_GET_CLASS(cpu); + +g_assert(cc->tcg_ops->has_work); +return cc->tcg_ops->has_work(cpu); +} Now, you're expecting cc->has_work to disappear as cc->tcg_ops->has_work a

[PATCH v5 08/31] accel/tcg: Implement AccelOpsClass::has_work() as stub

2021-09-20 Thread Philippe Mathieu-Daudé
Add TCG target-specific has_work() handler in TCGCPUOps, and add tcg_cpu_has_work() as AccelOpsClass has_work() implementation. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/tcg-cpu-ops.h | 4 accel/tcg/tcg-accel-ops.c | 10 ++ 2 files changed, 14 insertions(+) dif