Re: [PATCH v5 08/20] microvm/acpi: add minimal acpi support

2020-07-16 Thread Gerd Hoffmann
Hi, > > References to ACPI 2.0 are almost useless. ACPI 5.0 is the oldest > > version uefi.org offers for download. > all versions are at (starting from 1.0) > https://uefi.org/acpi/specs Ah, there are the old ones hidden. Thanks for the pointer. Fetched latest errata of each version (assumin

Re: [PATCH v5 08/20] microvm/acpi: add minimal acpi support

2020-07-10 Thread Igor Mammedov
On Thu, 9 Jul 2020 14:33:32 +0200 Gerd Hoffmann wrote: > Hi, > > > > +scope = aml_scope("\\"); > > > +pkg = aml_package(4); > > > +aml_append(pkg, aml_int(5)); /* SLEEP_CONTROL_REG.SLP_TYP */ > > > > I'm not sure what does the comment refer to here. > > It's the register fiel

Re: [PATCH v5 08/20] microvm/acpi: add minimal acpi support

2020-07-09 Thread Gerd Hoffmann
Hi, > > +scope = aml_scope("\\"); > > +pkg = aml_package(4); > > +aml_append(pkg, aml_int(5)); /* SLEEP_CONTROL_REG.SLP_TYP */ > > I'm not sure what does the comment refer to here. It's the register field the value gets written to. With full acpi this is PM1a_CNT.SLP_TYP, hw-reduce

Re: [PATCH v5 08/20] microvm/acpi: add minimal acpi support

2020-07-08 Thread Michael S. Tsirkin
On Tue, Jul 07, 2020 at 02:53:44PM +0200, Gerd Hoffmann wrote: > $subject says all. Can be controlled using -M microvm,acpi=on/off. > > Signed-off-by: Gerd Hoffmann Overall I don't see bugs here. Some comments are bit confusing and I point that out below. With that addressed: Reviewed-by: Mich

[PATCH v5 08/20] microvm/acpi: add minimal acpi support

2020-07-07 Thread Gerd Hoffmann
$subject says all. Can be controlled using -M microvm,acpi=on/off. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-microvm.h| 8 ++ include/hw/i386/microvm.h | 9 ++ hw/i386/acpi-microvm.c| 195 ++ hw/i386/microvm.c | 40 hw/i386/K