Re: [PATCH v5 08/20] linux-user: Load vdso image if available

2023-08-30 Thread Richard Henderson
On 8/30/23 13:56, Philippe Mathieu-Daudé wrote: +    for (unsigned i = 0, n = vdso->reloc_count; i < n; i++) { Do we really need 'n'? You should always have an loop invariant condition if possible. vdso->reloc_count doesn't seem updated, but I get your point. But the compiler doesn't know

Re: [PATCH v5 08/20] linux-user: Load vdso image if available

2023-08-30 Thread Philippe Mathieu-Daudé
On 30/8/23 18:17, Richard Henderson wrote: On 8/30/23 07:22, Philippe Mathieu-Daudé wrote: Hi Richard, On 30/8/23 00:02, Richard Henderson wrote: The vdso image will be pre-processed into a C data array, with a simple list of relocations to perform, and identifying the location of signal tramp

Re: [PATCH v5 08/20] linux-user: Load vdso image if available

2023-08-30 Thread Richard Henderson
On 8/30/23 07:22, Philippe Mathieu-Daudé wrote: Hi Richard, On 30/8/23 00:02, Richard Henderson wrote: The vdso image will be pre-processed into a C data array, with a simple list of relocations to perform, and identifying the location of signal trampolines. Signed-off-by: Richard Henderson -

Re: [PATCH v5 08/20] linux-user: Load vdso image if available

2023-08-30 Thread Philippe Mathieu-Daudé
Hi Richard, On 30/8/23 00:02, Richard Henderson wrote: The vdso image will be pre-processed into a C data array, with a simple list of relocations to perform, and identifying the location of signal trampolines. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 87 ++

[PATCH v5 08/20] linux-user: Load vdso image if available

2023-08-29 Thread Richard Henderson
The vdso image will be pre-processed into a C data array, with a simple list of relocations to perform, and identifying the location of signal trampolines. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 87 +++- 1 file changed, 78 insertions(+