Re: [PATCH v5 08/15] acpi: move aml builder code for floppy device

2020-05-15 Thread Gerd Hoffmann
> > +#include "hw/i386/pc.h" > > I'd rather not see this target-specific header used in the generic device > model... The culprit seems cmos_get_fd_drive_type(). Is the value really PC > specific? Given that the same value is used in acpi tables probably not really. cmos_get_fd_drive_type() hasn'

Re: [PATCH v5 08/15] acpi: move aml builder code for floppy device

2020-05-13 Thread Thomas Huth
On 13/05/2020 22.43, John Snow wrote: > > > On 5/7/20 10:05 AM, Philippe Mathieu-Daudé wrote: >> +Hervé >> >> On 5/7/20 3:16 PM, Gerd Hoffmann wrote: >>> Signed-off-by: Gerd Hoffmann >>> Reviewed-by: Igor Mammedov >>> --- >>>   hw/block/fdc.c   | 83 +

Re: [PATCH v5 08/15] acpi: move aml builder code for floppy device

2020-05-13 Thread John Snow
On 5/7/20 10:05 AM, Philippe Mathieu-Daudé wrote: > +Hervé > > On 5/7/20 3:16 PM, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann >> Reviewed-by: Igor Mammedov >> --- >>   hw/block/fdc.c   | 83 oh no... >>   hw/i386/acpi-build.c | 83 ---

Re: [PATCH v5 08/15] acpi: move aml builder code for floppy device

2020-05-07 Thread Philippe Mathieu-Daudé
+Hervé On 5/7/20 3:16 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/block/fdc.c | 83 hw/i386/acpi-build.c | 83 stubs/cmos.c | 7 stubs/

[PATCH v5 08/15] acpi: move aml builder code for floppy device

2020-05-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/block/fdc.c | 83 hw/i386/acpi-build.c | 83 stubs/cmos.c | 7 stubs/Makefile.objs | 1 + 4 files changed, 91 insertions(