> > +#include "hw/i386/pc.h"
>
> I'd rather not see this target-specific header used in the generic device
> model... The culprit seems cmos_get_fd_drive_type(). Is the value really PC
> specific?
Given that the same value is used in acpi tables probably not really.
cmos_get_fd_drive_type() hasn'
On 13/05/2020 22.43, John Snow wrote:
>
>
> On 5/7/20 10:05 AM, Philippe Mathieu-Daudé wrote:
>> +Hervé
>>
>> On 5/7/20 3:16 PM, Gerd Hoffmann wrote:
>>> Signed-off-by: Gerd Hoffmann
>>> Reviewed-by: Igor Mammedov
>>> ---
>>> hw/block/fdc.c | 83 +
On 5/7/20 10:05 AM, Philippe Mathieu-Daudé wrote:
> +Hervé
>
> On 5/7/20 3:16 PM, Gerd Hoffmann wrote:
>> Signed-off-by: Gerd Hoffmann
>> Reviewed-by: Igor Mammedov
>> ---
>> hw/block/fdc.c | 83
oh no...
>> hw/i386/acpi-build.c | 83 ---
+Hervé
On 5/7/20 3:16 PM, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
hw/block/fdc.c | 83
hw/i386/acpi-build.c | 83
stubs/cmos.c | 7
stubs/
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
hw/block/fdc.c | 83
hw/i386/acpi-build.c | 83
stubs/cmos.c | 7
stubs/Makefile.objs | 1 +
4 files changed, 91 insertions(