Re: [PATCH v5 05/10] ccid: build smartcard as module

2020-07-22 Thread Christophe de Dinechin
On 2020-07-21 at 16:33 CEST, Gerd Hoffmann wrote... >> > ifeq ($(CONFIG_USB_SMARTCARD),y) >> > common-obj-y += dev-smartcard-reader.o >> >> I'm curious why you don't use something like: >> >> common-obj-$(CONFIG_USB_SMARTCARD) >> >> Do we want to be able to configure in

Re: [PATCH v5 05/10] ccid: build smartcard as module

2020-07-21 Thread Gerd Hoffmann
> > ifeq ($(CONFIG_USB_SMARTCARD),y) > > common-obj-y += dev-smartcard-reader.o > > I'm curious why you don't use something like: > > common-obj-$(CONFIG_USB_SMARTCARD) > > Do we want to be able to configure individual elements as modules? > Or is the intent to force a

Re: [PATCH v5 05/10] ccid: build smartcard as module

2020-07-20 Thread Christophe de Dinechin
On 2020-06-24 at 15:10 CEST, Gerd Hoffmann wrote... > Drops libcacard.so dependency from core qemu. > > Signed-off-by: Gerd Hoffmann > --- > Makefile.objs| 1 + > util/module.c| 2 ++ > hw/Makefile.objs | 1 + > hw/usb/Makefile.objs | 4 +++- > 4 files changed, 7 insertions(

[PATCH v5 05/10] ccid: build smartcard as module

2020-06-24 Thread Gerd Hoffmann
Drops libcacard.so dependency from core qemu. Signed-off-by: Gerd Hoffmann --- Makefile.objs| 1 + util/module.c| 2 ++ hw/Makefile.objs | 1 + hw/usb/Makefile.objs | 4 +++- 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile.objs b/Makefile.objs index 7ce