Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

Markus Armbruster wrote: > It's less terse. Fine with me. The mix of passive and active voice > feels a bit awkward, though. Another try: > > All .c should include qemu/osdep.h first. This script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > *

Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Markus Armbruster wrote: Juan Quintela writes: > Markus Armbruster wrote: >> The script drops #include "qemu/osdep.h" from headers. Mention it in >> the commit message it uses for --git. >

Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

Markus Armbruster wrote: > Juan Quintela writes: > >> Markus Armbruster wrote: >>> Juan Quintela writes: >>> Markus Armbruster wrote: > The script drops #include "qemu/osdep.h" from headers. Mention it in > the commit message it uses for --git. > > Signed-off-by: Markus A

Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Markus Armbruster wrote: The script drops #include "qemu/osdep.h" from headers. Mention it in the commit message it uses for --git. Signed-off-by: Markus Armbruster --- scripts/cle

Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

Markus Armbruster wrote: > Juan Quintela writes: > >> Markus Armbruster wrote: >>> The script drops #include "qemu/osdep.h" from headers. Mention it in >>> the commit message it uses for --git. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> scripts/clean-includes | 4 ++-- >>> 1 file ch

Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

Juan Quintela writes: > Markus Armbruster wrote: >> The script drops #include "qemu/osdep.h" from headers. Mention it in >> the commit message it uses for --git. >> >> Signed-off-by: Markus Armbruster >> --- >> scripts/clean-includes | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-

Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

Markus Armbruster wrote: > The script drops #include "qemu/osdep.h" from headers. Mention it in > the commit message it uses for --git. > > Signed-off-by: Markus Armbruster > --- > scripts/clean-includes | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/clean-

[PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

The script drops #include "qemu/osdep.h" from headers. Mention it in the commit message it uses for --git. Signed-off-by: Markus Armbruster --- scripts/clean-includes | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/clean-includes b/scripts/clean-includes index f0