Re: [PATCH v5 04/19] accel/tcg: Adjust probe_access call to page_check_range

2020-05-11 Thread Peter Maydell
On Fri, 8 May 2020 at 17:57, Richard Henderson wrote: > On 5/8/20 9:13 AM, Peter Maydell wrote: > > We've gone round this multiple times now so I feel like > > I must be missing something here. > > While probe_access() has a size parameter, probe_access_flags() does not. > > For probe_access_inter

Re: [PATCH v5 04/19] accel/tcg: Adjust probe_access call to page_check_range

2020-05-08 Thread Richard Henderson
On 5/8/20 9:13 AM, Peter Maydell wrote: > On Fri, 8 May 2020 at 16:44, Richard Henderson > wrote: >> >> We have validated that addr+size does not cross a page boundary. >> Therefore we need to validate exactly one page. We can achieve >> that passing any value 1 <= x <= size to page_check_range.

Re: [PATCH v5 04/19] accel/tcg: Adjust probe_access call to page_check_range

2020-05-08 Thread Peter Maydell
On Fri, 8 May 2020 at 16:44, Richard Henderson wrote: > > We have validated that addr+size does not cross a page boundary. > Therefore we need to validate exactly one page. We can achieve > that passing any value 1 <= x <= size to page_check_range. > > Passing 1 will simplify the next patch. It'

[PATCH v5 04/19] accel/tcg: Adjust probe_access call to page_check_range

2020-05-08 Thread Richard Henderson
We have validated that addr+size does not cross a page boundary. Therefore we need to validate exactly one page. We can achieve that passing any value 1 <= x <= size to page_check_range. Passing 1 will simplify the next patch. Signed-off-by: Richard Henderson --- accel/tcg/user-exec.c | 2 +-