Re: [PATCH v5 04/12] pc-bios: s390x: Get rid of magic offsets into the lowcore

2020-06-29 Thread Cornelia Huck
On Wed, 24 Jun 2020 03:52:18 -0400 Janosch Frank wrote: > If we have a lowcore struct that has members for offsets that we want > to touch, why not use it? > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > --- > pc-bios/s390-ccw/cio.h | 17 +++-- > pc-bios/s390-

Re: [PATCH v5 04/12] pc-bios: s390x: Get rid of magic offsets into the lowcore

2020-06-25 Thread Thomas Huth
On 24/06/2020 09.52, Janosch Frank wrote: If we have a lowcore struct that has members for offsets that we want to touch, why not use it? Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- pc-bios/s390-ccw/cio.h | 17 +++-- pc-bios/s390-ccw/main.c | 8 +++- 2

[PATCH v5 04/12] pc-bios: s390x: Get rid of magic offsets into the lowcore

2020-06-24 Thread Janosch Frank
If we have a lowcore struct that has members for offsets that we want to touch, why not use it? Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- pc-bios/s390-ccw/cio.h | 17 +++-- pc-bios/s390-ccw/main.c | 8 +++- 2 files changed, 14 insertions(+), 11 deletions(