Re: [PATCH v5 03/10] qdev: device module support

2020-07-22 Thread Christophe de Dinechin
On 2020-07-22 at 13:05 CEST, Gerd Hoffmann wrote... > On Wed, Jul 22, 2020 at 10:05:51AM +0200, Christophe de Dinechin wrote: >> >> On 2020-07-21 at 16:27 CEST, Gerd Hoffmann wrote... >> > Hi, >> > >> >> > DeviceState *qdev_new(const char *name) >> >> > { >> >> > +if (!object_class_by_nam

Re: [PATCH v5 03/10] qdev: device module support

2020-07-22 Thread Gerd Hoffmann
On Wed, Jul 22, 2020 at 10:05:51AM +0200, Christophe de Dinechin wrote: > > On 2020-07-21 at 16:27 CEST, Gerd Hoffmann wrote... > > Hi, > > > >> > DeviceState *qdev_new(const char *name) > >> > { > >> > +if (!object_class_by_name(name)) { > >> > +module_load_qom_one(name); > >> > +

Re: [PATCH v5 03/10] qdev: device module support

2020-07-22 Thread Christophe de Dinechin
On 2020-07-21 at 16:27 CEST, Gerd Hoffmann wrote... > Hi, > >> > DeviceState *qdev_new(const char *name) >> > { >> > +if (!object_class_by_name(name)) { >> > +module_load_qom_one(name); >> > +} >> >> Curious why you don't you call module_object_class_by_name here? > > Because

Re: [PATCH v5 03/10] qdev: device module support

2020-07-21 Thread Gerd Hoffmann
Hi, > > DeviceState *qdev_new(const char *name) > > { > > +if (!object_class_by_name(name)) { > > +module_load_qom_one(name); > > +} > > Curious why you don't you call module_object_class_by_name here? Because object_new() wants a name not an ObjectClass ... > > return

Re: [PATCH v5 03/10] qdev: device module support

2020-07-20 Thread Christophe de Dinechin
On 2020-06-24 at 15:10 CEST, Gerd Hoffmann wrote... > Hook module loading into the places where we > need it when building devices as modules. > > Signed-off-by: Gerd Hoffmann > --- > hw/core/qdev.c | 6 -- > qdev-monitor.c | 5 +++-- > qom/qom-qmp-cmds.c | 3 ++- > softmmu/vl.c

[PATCH v5 03/10] qdev: device module support

2020-06-24 Thread Gerd Hoffmann
Hook module loading into the places where we need it when building devices as modules. Signed-off-by: Gerd Hoffmann --- hw/core/qdev.c | 6 -- qdev-monitor.c | 5 +++-- qom/qom-qmp-cmds.c | 3 ++- softmmu/vl.c | 4 ++-- 4 files changed, 11 insertions(+), 7 deletions(-) diff --