Re: [PATCH v5 02/17] pci: Allow to omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
On 2022/10/29 7:35, Philippe Mathieu-Daudé wrote: On 28/10/22 14:26, Akihiko Odaki wrote: pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned valu

Re: [PATCH v5 02/17] pci: Allow to omit errp for pci_add_capability

2022-10-28 Thread Philippe Mathieu-Daudé
On 28/10/22 14:26, Akihiko Odaki wrote: pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the

[PATCH v5 02/17] pci: Allow to omit errp for pci_add_capability

2022-10-28 Thread Akihiko Odaki
pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring The