Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-24 Thread Keqian Zhu
Peter, On 2021/3/24 23:09, Peter Xu wrote: > On Wed, Mar 24, 2021 at 10:56:22AM +0800, Keqian Zhu wrote: >> Hi Peter, >> >> On 2021/3/23 22:34, Peter Xu wrote: >>> Keqian, >>> >>> On Tue, Mar 23, 2021 at 02:40:43PM +0800, Keqian Zhu wrote: >> The second question is that you observed longer mig

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-24 Thread Peter Xu
On Wed, Mar 24, 2021 at 10:56:22AM +0800, Keqian Zhu wrote: > Hi Peter, > > On 2021/3/23 22:34, Peter Xu wrote: > > Keqian, > > > > On Tue, Mar 23, 2021 at 02:40:43PM +0800, Keqian Zhu wrote: > The second question is that you observed longer migration time > (55s->73s) when guest > >>>

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-23 Thread Keqian Zhu
Hi Peter, On 2021/3/23 22:34, Peter Xu wrote: > Keqian, > > On Tue, Mar 23, 2021 at 02:40:43PM +0800, Keqian Zhu wrote: The second question is that you observed longer migration time (55s->73s) when guest has 24G ram and dirty rate is 800M/s. I am not clear about the reason. As >

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-23 Thread Peter Xu
Keqian, On Tue, Mar 23, 2021 at 02:40:43PM +0800, Keqian Zhu wrote: > >> The second question is that you observed longer migration time (55s->73s) > >> when guest > >> has 24G ram and dirty rate is 800M/s. I am not clear about the reason. As > >> with dirty > >> ring enabled, Qemu can get dirty

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-22 Thread Keqian Zhu
Hi Peter, On 2021/3/23 3:45, Peter Xu wrote: > On Mon, Mar 22, 2021 at 10:02:38PM +0800, Keqian Zhu wrote: >> Hi Peter, > > Hi, Keqian, > > [...] > >> You emphasize that dirty ring is a "Thread-local buffers", but dirty bitmap >> is global, >> but I don't see it has optimization about "locking

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-22 Thread Peter Xu
On Mon, Mar 22, 2021 at 10:02:38PM +0800, Keqian Zhu wrote: > Hi Peter, Hi, Keqian, [...] > You emphasize that dirty ring is a "Thread-local buffers", but dirty bitmap > is global, > but I don't see it has optimization about "locking" compared to dirty bitmap. > > The thread-local means that v

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-22 Thread Keqian Zhu
Hi Peter, On 2021/3/11 4:32, Peter Xu wrote: > This is v5 of the qemu dirty ring interface support. > > > > v5: > > - rebase > > - dropped patch "update-linux-headers: Include const.h" after rebase > > - dropped patch "KVM: Fixup kvm_log_clear_one_slot() ioctl return check" since > > simi

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-19 Thread Peter Xu
On Wed, Mar 10, 2021 at 03:32:51PM -0500, Peter Xu wrote: > This is v5 of the qemu dirty ring interface support. > > v5: > - rebase > - dropped patch "update-linux-headers: Include const.h" after rebase > - dropped patch "KVM: Fixup kvm_log_clear_one_slot() ioctl return check" since > similar pa

[PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-10 Thread Peter Xu
This is v5 of the qemu dirty ring interface support. v5: - rebase - dropped patch "update-linux-headers: Include const.h" after rebase - dropped patch "KVM: Fixup kvm_log_clear_one_slot() ioctl return check" since similar patch got merged recently (38e0b7904eca7cd32f8953c3) = v4 cover l