Re: [PATCH v5 0/6] crypto: Make QCryptoTLSCreds* structures private

2021-06-28 Thread Philippe Mathieu-Daudé
On 6/28/21 5:56 AM, Akihiko Odaki wrote: > Hi, > > qemu-nbd.c still refers to members of QCryptoTLSCreds* and can't be > compiled. Thanks for testing, I'll have a look. > > Regards, > Akihiko Odaki > > On 2021/06/17 21:18, Philippe Mathieu-Daudé wrote: >> Missing review: 5 & 6 >> >> Follow Dan

Re: [PATCH v5 0/6] crypto: Make QCryptoTLSCreds* structures private

2021-06-27 Thread Akihiko Odaki
Hi, qemu-nbd.c still refers to members of QCryptoTLSCreds* and can't be compiled. Regards, Akihiko Odaki On 2021/06/17 21:18, Philippe Mathieu-Daudé wrote: Missing review: 5 & 6 Follow Daniel suggestion to simplify qcrypto TLS implementations, aiming to solve the OSX build failure. Since v

[PATCH v5 0/6] crypto: Make QCryptoTLSCreds* structures private

2021-06-17 Thread Philippe Mathieu-Daudé
Missing review: 5 & 6 Follow Daniel suggestion to simplify qcrypto TLS implementations, aiming to solve the OSX build failure. Since v4: - Do not introduce qcrypto_tls_session_check_role (Richard, Daniel) - Added R-b tags Since v3: - Added missing @errp docstring description Since v2: - Add Err