Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-23 Thread P J P
+-- On Mon, 23 Mar 2020, Jason Wang wrote --+ | Prasad, please fix this and post a new version. | | While at it, I prefer to squash patch 3 into patch 2 since patch 3 fixes the | issue introduced by patch 2. Sent patch v6. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 8685 545E

Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-23 Thread Jason Wang
On 2020/3/23 下午1:40, P J P wrote: +-- On Mon, 23 Mar 2020, P J P wrote --+ | +-- On Mon, 23 Mar 2020, Jason Wang wrote --+ | | hw/net/tulip.c:305:20: error: initialization of ‘_Bool (*)(NetClientState *)’ | | {aka ‘_Bool (*)(struct NetClientState *)’} from incompatible pointer type ‘int | | (

Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-22 Thread Li Qiang
Jason Wang 于2020年3月23日周一 上午11:44写道: > > On 2020/3/20 上午1:40, P J P wrote: > > From: Prasad J Pandit > > > > Hello, > > > > * This series adds checks to avoid potential OOB access and infinite loop > >issues while processing rx/tx data. > > > > * Tulip tx descriptors are capped at 128 to avoi

Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-22 Thread P J P
+-- On Mon, 23 Mar 2020, P J P wrote --+ | +-- On Mon, 23 Mar 2020, Jason Wang wrote --+ | | hw/net/tulip.c:305:20: error: initialization of ‘_Bool (*)(NetClientState *)’ | | {aka ‘_Bool (*)(struct NetClientState *)’} from incompatible pointer type ‘int | | (*)(NetClientState *)’ {aka ‘int (*)(st

Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-22 Thread P J P
+-- On Mon, 23 Mar 2020, Jason Wang wrote --+ | hw/net/tulip.c:305:20: error: initialization of ‘_Bool (*)(NetClientState *)’ | {aka ‘_Bool (*)(struct NetClientState *)’} from incompatible pointer type ‘int | (*)(NetClientState *)’ {aka ‘int (*)(struct NetClientState *)’} | [-Werror=incompatible-po

Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-22 Thread Jason Wang
On 2020/3/23 上午11:43, Jason Wang wrote: On 2020/3/20 上午1:40, P J P wrote: From: Prasad J Pandit Hello, * This series adds checks to avoid potential OOB access and infinite loop    issues while processing rx/tx data. * Tulip tx descriptors are capped at 128 to avoid infinite loop in    t

Re: [PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-22 Thread Jason Wang
On 2020/3/20 上午1:40, P J P wrote: From: Prasad J Pandit Hello, * This series adds checks to avoid potential OOB access and infinite loop issues while processing rx/tx data. * Tulip tx descriptors are capped at 128 to avoid infinite loop in tulip_xmit_list_update(), wrt Tulip kernel dr

[PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-19 Thread P J P
From: Prasad J Pandit Hello, * This series adds checks to avoid potential OOB access and infinite loop issues while processing rx/tx data. * Tulip tx descriptors are capped at 128 to avoid infinite loop in tulip_xmit_list_update(), wrt Tulip kernel driver -> https://git.kernel.org/pub/sc