Re: [PATCH v5] replay: do not build if TCG is not available

2020-10-21 Thread Paolo Bonzini
On 21/10/20 16:46, Claudio Fontana wrote: > in your respin you have not included my change which surrounds > > if (replay_can_snapshot()) > > around a > > if (tcg_enabled()) { > } > > therefore leading to failure of all attempts to snapshot under --disable-tcg. > > Alternatively, you can chang

Re: [PATCH v5] replay: do not build if TCG is not available

2020-10-21 Thread Claudio Fontana
Hi Paolo, On 10/21/20 2:37 PM, Paolo Bonzini wrote: > From: Claudio Fontana > > this fixes non-TCG builds broken recently by replay reverse debugging. > > Stub the needed functions in stub/, splitting roughly between functions > needed only by system emulation, by system emulation and tools, >

[PATCH v5] replay: do not build if TCG is not available

2020-10-21 Thread Paolo Bonzini
From: Claudio Fontana this fixes non-TCG builds broken recently by replay reverse debugging. Stub the needed functions in stub/, splitting roughly between functions needed only by system emulation, by system emulation and tools, and by everyone. This includes duplicating some code in replay/, a